Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

Use HBAI population groups for UK poverty breakdowns; stop requesting the deprecated is_child/is_adult

未关闭
  • 哪里不对？
#537 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
重构
描述清晰度
基本清楚
活跃度
活跃
技术栈
python
领域
backend, data

调研方向

Start with src/policyengine/tax_benefit_models/uk/model.py and uk/household.py, then inspect src/policyengine/outputs/poverty.py and cliff_impact.py. Confirm the policyengine-uk pin includes the HBAI variables, and run the existing snapshot and poverty tests before changing the UK output keys. Done means deprecated UK variables are no longer read, HBAI groups reproduce the enhanced FRS split, and snapshots, poverty tests, executor keys, and labels are consistent.

由索引模型根据 Issue 内容生成。

描述

Why

PolicyEngine/policyengine-uk#1896 replaces the generic is_child (age < 18) and is_adult (age >= 18) flags inside the UK model with each programme's legal definition, and adds explicit HBAI (Households Below Average Income) variables for statistics. UK law has no single definition of a child: Child Benefit, Universal Credit, tax credits, Pension Credit, the legacy benefits and student support each define their own, and HBAI defines a dependent child as under 16, or 16-19, unpartnered, living with parents and in full-time non-advanced education or unwaged government training.

is_child, is_adult, family_type and the other generic variables stay in policyengine-uk as deprecated shims with their old age-18 formulas, so nothing breaks. This issue moves policyengine.py onto the explicit variables once its policyengine-uk pin moves past the release containing that PR.

Changes

  1. src/policyengine/tax_benefit_models/uk/model.py: drop is_adult and is_child from the UK person output columns (lines ~63-65) and add hbai_person_type (enum: CHILD, WORKING_AGE_ADULT, PENSIONER) or is_hbai_dependent_child. Replace the benunit family_type column (line ~94; deprecated, age-18 split) with relation_type (claimant has a partner) if a family column is still wanted. Update uk/household.py accordingly and regenerate the UK household snapshot fixtures.
  2. src/policyengine/outputs/poverty.py: UK poverty by group should use the HBAI population groups, not the age bands in AGE_GROUPS (child <= 17, adult 18-64, senior 65+). HBAI groups: dependent children, working-age adults (below State Pension age) and pensioners (at or above State Pension age), i.e. hbai_person_type. Keep age bands where an age band is meant, but label them as age bands (for example aged_0_to_17, aged_18_to_64, aged_65_and_over), and keep the US groups separate from the UK ones. The api-v2 simulation executor and the app's "Children / Working-age adults / Seniors" labels read these groups: coordinate the key change (for the UK, "Seniors" should read "Pensioners").
  3. src/policyengine/outputs/cliff_impact.py: the cliff-share denominator sums is_adult. Make it an explicit per-country predicate (for the UK, people aged 18 or over via age, or is_hbai_adult if the intended population is HBAI adults) and document it; the numerator currently counts everyone.

Acceptance

  • No policyengine.py code reads a deprecated UK variable (is_child, is_adult, num_children, num_adults, family_type, child_index, adult_index excepted).
  • UK poverty-by-group outputs reproduce HBAI's population split on the enhanced FRS.
  • Snapshot and poverty tests updated.

🤖 Generated with Claude Code

主要语言
Python
星标
8
派生
10
平均合并
21 小时 34 分钟
30 天内合并 PR
45

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

PolicyEngine/policyengine.py 的其他 Issue

查看 PolicyEngine/policyengine.py 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。