Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Use HBAI population groups for UK poverty breakdowns; stop requesting the deprecated is_child/is_adult

Aperta
  • Qualcosa non va?
#537 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Refactoring
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
python
Ambito
backend, data

Direzione di ricerca

Start with src/policyengine/tax_benefit_models/uk/model.py and uk/household.py, then inspect src/policyengine/outputs/poverty.py and cliff_impact.py. Confirm the policyengine-uk pin includes the HBAI variables, and run the existing snapshot and poverty tests before changing the UK output keys. Done means deprecated UK variables are no longer read, HBAI groups reproduce the enhanced FRS split, and snapshots, poverty tests, executor keys, and labels are consistent.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Why

PolicyEngine/policyengine-uk#1896 replaces the generic is_child (age < 18) and is_adult (age >= 18) flags inside the UK model with each programme's legal definition, and adds explicit HBAI (Households Below Average Income) variables for statistics. UK law has no single definition of a child: Child Benefit, Universal Credit, tax credits, Pension Credit, the legacy benefits and student support each define their own, and HBAI defines a dependent child as under 16, or 16-19, unpartnered, living with parents and in full-time non-advanced education or unwaged government training.

is_child, is_adult, family_type and the other generic variables stay in policyengine-uk as deprecated shims with their old age-18 formulas, so nothing breaks. This issue moves policyengine.py onto the explicit variables once its policyengine-uk pin moves past the release containing that PR.

Changes

  1. src/policyengine/tax_benefit_models/uk/model.py: drop is_adult and is_child from the UK person output columns (lines ~63-65) and add hbai_person_type (enum: CHILD, WORKING_AGE_ADULT, PENSIONER) or is_hbai_dependent_child. Replace the benunit family_type column (line ~94; deprecated, age-18 split) with relation_type (claimant has a partner) if a family column is still wanted. Update uk/household.py accordingly and regenerate the UK household snapshot fixtures.
  2. src/policyengine/outputs/poverty.py: UK poverty by group should use the HBAI population groups, not the age bands in AGE_GROUPS (child <= 17, adult 18-64, senior 65+). HBAI groups: dependent children, working-age adults (below State Pension age) and pensioners (at or above State Pension age), i.e. hbai_person_type. Keep age bands where an age band is meant, but label them as age bands (for example aged_0_to_17, aged_18_to_64, aged_65_and_over), and keep the US groups separate from the UK ones. The api-v2 simulation executor and the app's "Children / Working-age adults / Seniors" labels read these groups: coordinate the key change (for the UK, "Seniors" should read "Pensioners").
  3. src/policyengine/outputs/cliff_impact.py: the cliff-share denominator sums is_adult. Make it an explicit per-country predicate (for the UK, people aged 18 or over via age, or is_hbai_adult if the intended population is HBAI adults) and document it; the numerator currently counts everyone.

Acceptance

  • No policyengine.py code reads a deprecated UK variable (is_child, is_adult, num_children, num_adults, family_type, child_index, adult_index excepted).
  • UK poverty-by-group outputs reproduce HBAI's population split on the enhanced FRS.
  • Snapshot and poverty tests updated.

🤖 Generated with Claude Code

Lingua principale
Python
Stelle
8
Fork
10
Merge medio
12h 26m
PR unite (30g)
22

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di PolicyEngine/policyengine.py

Tutte le issue di PolicyEngine/policyengine.py

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.