Quarantine or fix known-broken tests on main (Blosc2, AskRequest)
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 38/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 冷清
- 技术栈
- javascript, python
调研方向
从 tests/to_refactor/python/test_us_policy_macro.py::test_utah、tests/test_household_calculation.py、tests/test_agent.py 和 app/src/tests/unit/libs/migration/* 开始;运行受影响的测试套件,以确认列出的失败。检查每个 repository 现有的测试和 CI 配置,然后确保每个已知失败要么得到修复,要么被明确隔离并单独呈现,同时不掩盖回归问题。
由索引模型根据 Issue 内容生成。
描述
Summary
Several test failures are known-broken on main across repos but are neither fixed nor quarantined. Every PR body ends up noting "these failures predate this PR" instead of the suite being green. This makes real regressions harder to spot.
What goes wrong
policyengine-api
tests/to_refactor/python/test_us_policy_macro.py::test_utahhangs locally; module referencespolicyengine_api/worker.pythat no longer exists. Confirmed on master by multiple agents.
policyengine-api-v2 (simulation project)
tests/test_household_calculation.py— macOS-only Blosc2 import failures.tests/test_agent.py—AskRequestImportError.
policyengine-app-v2
- 40 failures in
app/src/tests/unit/libs/migration/*fromlocalStorage.clear is not a function.
Suggested fix
Per repo, either:
- Fix the underlying issue (preferred), or
- Quarantine with an explicit marker so the default suite is green:
# pytest
@pytest.mark.skip(reason="Broken on main — tracked in #NNNN, fix pending")
def test_utah(): ...
# vitest
it.skip('migration test — localStorage.clear not a function, tracked in #NNNN', ...)
- Surface via a separate CI job (
pytest -m broken) that's allowed to fail, so the status is visible without masking real regressions.
The anti-pattern to eliminate: PR authors noting "these failures predate this PR" in every review. If they predate every PR, they should be marked so CI reflects that.
Severity
Medium (dev-experience). Hides real regressions, creates review friction, breaks the "CI green = merge" invariant.
Scope
Filing this in three repos: policyengine-api, policyengine-api-v2, policyengine-app-v2.
- 主要语言
- Python
- 星标
- 1
- 派生
- 1
- 平均合并
- 15 小时 10 分钟
- 30 天内合并 PR
- 12
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
PolicyEngine/policyengine-sim-api 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 65/100
-
难度 3/5 1-2 天 新手友好度 65/100
-
难度 5/5 一周以上 新手友好度 35/100
-
难度 4/5 3-5 天 新手友好度 35/100
-
难度 4/5 3-5 天 新手友好度 45/100
PolicyEngine/policyengine-sim-api#674 · 3 条评论 ·
查看 PolicyEngine/policyengine-sim-api 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 75/100
stephrobert/dsoxlab#238 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 75/100
sublimehq/package_control#1780 ·
-
难度 2/5 1-3 小时 新手友好度 65/100
-
难度 2/5 1-3 小时 新手友好度 70/100
nwg-piotr/nwg-displays#145 ·