Missing Trade Encounters
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
从 Encounter_Conditions.csv、链接的 Pokémon XD: Gale of Darkness PR 以及链接的 Bulbapedia generation-I 交换列表开始；对比现有的 generation 7 NPC 交换数据。完成标准是：所选 generation 的 NPC 交换遭遇已得到表示，包括交换条件以及 NPC 或所请求 Pokémon 的详细信息，但不涵盖玩家之间的交换。
由索引模型根据 Issue 内容生成。
描述
The API is missing a lot of trade encounters, what I've noticed so far is:
All RBY trades are missing.
All GSC Trades are missing:
All RSE Trades are missing:
All FRLG Trades are missing:
All G4 Trades are missing in HGSS and DPPt:
All G5 Trades are missing in BW and B2W2:
All G6 Trades are missing in XY/ORAS:
Gen 7 is the only gen with encounters that actually has the NPC trades, and it has them for both LGPE and SM/USUM!
Obviously they're missing in gens 8/9 as well, but there's currently no encounter data at all for them yet in the API anyway.
In addition to this, as discussed in my PR for Pokemon XD: Gale of Darkness, I think we should be add a new Encounter_Condition in Encounter_Conditions.csv called Trade.
And then, when adding NPC-Trade encounters to the API, we should add an encounter condition for each one that says what Pokemon to trade for them, and what the NPCs name is if they're named. Let's use Mimien the Mr. Mime as an example:
- 108,15,trade-REYLEY-abra,0
This notes which NPC to trade with and which Pokemon to give them. We would have to go back and add the conditions for the gen 7 pokemon trades as well.
Lastly, I do think it's important to have this data in the API. Certain Pokemon are only catchable in games via trade from an NPC, such as Mr Mime, Farfech'd, and a few others.
Things I think this issue should not cover:
- Trading for a Pokemon with another real gameboy
That is a much bigger task, out of scope with the NPC-Trade encounter_method, and also solvable by the end user.
Currently I'm working on a website with a friend and we can have the site display trade or transfer from X game just by using logic to deduce if the Pokemon is in the selected game or not, and what is the nearest game you could receive it from, so I don't think it's necessary to include in the API at all.
As with any issue like this I bring up, I'm of course willing to do the work and write down all these encounters. I would probably do 1 PR per gen as to not make a massive PR with like 85 trade pokemon from 7 regions and 10 games.
I would start with gen 1 and work my way up, but if anyone is interested in doing any of these I'd ask you post here so we don't both do the same gen at once!
- 主要语言
- Python
- 星标
- 5.4k
- 派生
- 1.2k
- 平均合并
- 2 天 7 小时
- 30 天内合并 PR
- 17
环境准备
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
PokeAPI/pokeapi 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 82/100
PokeAPI/pokeapi#1685 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
PokeAPI/pokeapi#1684 · 1 个 reaction ·
维护者通常 1 天内回复
-
难度 2/5 1-2 天 新手友好度 76/100
PokeAPI/pokeapi#1631 · 3 条评论 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 58/100
PokeAPI/pokeapi#1687 · 4 条评论 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 55/100
PokeAPI/pokeapi#1623 · 3 条评论 ·
维护者通常 1 天内回复
相似的 Issue
-
pydanty:is-working
难度 2/5 1-3 小时 新手友好度 78/100
pydantic/pydantic-ai#8843 ·
维护者通常 1 天内回复
-
breaking change enhancement server
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 88/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
needs-triage
难度 2/5 1-3 小时 新手友好度 85/100
维护者通常 1 天内回复