Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Missing Trade Encounters

Aperta
  • Qualcosa non va?
#1,451 8 commenti 2 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
45/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Tranquilla
Stack tecnologico
python
Ambito
api, database

Direzione di ricerca

Inizia con Encounter_Conditions.csv, il PR collegato di Pokémon XD: Gale of Darkness e l’elenco degli scambi di generation-I collegato di Bulbapedia; confronta i dati esistenti sugli scambi con NPC di generation 7. Il lavoro è completo quando sono rappresentati gli incontri di scambio con NPC della generation scelta, inclusi la condizione dello scambio e i dettagli dell’NPC o del Pokémon richiesto, senza includere gli scambi tra giocatori.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

The API is missing a lot of trade encounters, what I've noticed so far is:

All RBY trades are missing.

All GSC Trades are missing:

All RSE Trades are missing:

All FRLG Trades are missing:

All G4 Trades are missing in HGSS and DPPt:

All G5 Trades are missing in BW and B2W2:

All G6 Trades are missing in XY/ORAS:

Gen 7 is the only gen with encounters that actually has the NPC trades, and it has them for both LGPE and SM/USUM!

Obviously they're missing in gens 8/9 as well, but there's currently no encounter data at all for them yet in the API anyway.

In addition to this, as discussed in my PR for Pokemon XD: Gale of Darkness, I think we should be add a new Encounter_Condition in Encounter_Conditions.csv called Trade.

And then, when adding NPC-Trade encounters to the API, we should add an encounter condition for each one that says what Pokemon to trade for them, and what the NPCs name is if they're named. Let's use Mimien the Mr. Mime as an example:

  • 108,15,trade-REYLEY-abra,0

This notes which NPC to trade with and which Pokemon to give them. We would have to go back and add the conditions for the gen 7 pokemon trades as well.

Lastly, I do think it's important to have this data in the API. Certain Pokemon are only catchable in games via trade from an NPC, such as Mr Mime, Farfech'd, and a few others.

Things I think this issue should not cover:

  • Trading for a Pokemon with another real gameboy

That is a much bigger task, out of scope with the NPC-Trade encounter_method, and also solvable by the end user.

Currently I'm working on a website with a friend and we can have the site display trade or transfer from X game just by using logic to deduce if the Pokemon is in the selected game or not, and what is the nearest game you could receive it from, so I don't think it's necessary to include in the API at all.

As with any issue like this I bring up, I'm of course willing to do the work and write down all these encounters. I would probably do 1 PR per gen as to not make a massive PR with like 85 trade pokemon from 7 regions and 10 games.

I would start with gen 1 and work my way up, but if anyone is interested in doing any of these I'd ask you post here so we don't both do the same gen at once!

Lingua principale
Python
Stelle
5.4k
Fork
1.2k
Merge medio
2g 7h
PR unite (30g)
17

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di PokeAPI/pokeapi

Tutte le issue di PokeAPI/pokeapi

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.