Bug: Funnel has_profile filter conflicts with the profile_id aggregate alias (ClickHouse Code 184)

未关闭
#663 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
76/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
clickhouse, typescript

调研方向

Read packages/core/src/modules/chart/src/filter-where.ts around the has_profile translation, then trace how funnel.sql.ts passes the events qualifier and builds the session-grouped aggregate and WHERE prefilter. Start by checking existing funnel tests for both has_profile values and profile-grouped behavior. Done means the session-grouped filters execute successfully and return the expected identified and anonymous sessions; add database-backed coverage with prefer_column_name_to_alias = 0.

由索引模型根据 Issue 内容生成。

描述

Summary

Session-grouped funnel queries use argMax(profile_id, created_at) AS profile_id while the built-in has_profile filter generates an unqualified profile_id != device_id or profile_id = device_id predicate. The funnel builder places these predicates in the same SELECT's WHERE clause.

ClickHouse can resolve profile_id in the predicate to the aggregate alias instead of the input column, causing Code 184 (ILLEGAL_AGGREGATION). This alias-resolution failure was reproduced locally with the reduced SQL below.

All dates and identifiers below are synthetic. No application data is required for the SQL example.

Version checked

  • Repository: Openpanel-dev/openpanel
  • Branch: main
  • Commit: a5a6eb7d62c9579620ec5e3fbfd4ce760f3d8073
  • ClickHouse local: 26.2.4.23, with prefer_column_name_to_alias returning false and no override supplied.
  • Verification: source inspection and execution of reduced SQL against ClickHouse local. A full Dashboard/API/database test was not run for this commit.

Steps to reproduce

The application steps below follow the inspected code path; they have not been executed end to end for this report.

  1. Use a valid funnel request in a local development environment and set funnelGroup to session_id.
  2. Add a step filter with name: "has_profile" and value: ["true"], keeping the remaining request fields valid.
  3. Inspect the generated SQL and execute the query against ClickHouse.
  4. Repeat with value: ["false"].

The relevant SQL fragments are equivalent to:

-- SELECT: aggregate output reuses the input column name
argMax(profile_id, created_at) AS profile_id

-- WHERE: has_profile predicate uses the unqualified name
profile_id != device_id -- true
profile_id = device_id  -- false

The filter builder receives the events qualifier, but the has_profile branch does not apply it. Step conditions are used both in windowFunnel and in the WHERE prefilter.

Minimal SQL example

This isolates the SELECT/WHERE alias conflict without accessing application tables. It omits windowFunnel, joins, and other request conditions.

Run with clickhouse-local --query "<SQL below>":

SELECT
    session_id,
    argMax(profile_id, created_at) AS profile_id
FROM VALUES(
    'session_id String, profile_id String, device_id String, created_at DateTime',
    ('s1', 'p1', 'd1', '2026-01-01 00:00:00'),
    ('s2', 'd2', 'd2', '2026-01-01 00:00:00')
) AS events
WHERE profile_id != device_id
GROUP BY session_id
FORMAT JSONEachRow

Expected behavior

The filter should compare input event columns before aggregation, and a supported has_profile filter should not introduce an aggregate into WHERE through alias resolution.

For the synthetic fixture, identified filtering should return session s1; anonymous filtering should return session s2.

Actual behavior

The minimal SQL example exited with code 184:

Code: 184. DB::Exception: Aggregate function argMax(profile_id, created_at) AS profile_id is found in WHERE in query. (ILLEGAL_AGGREGATION)

Replacing != with = produced the same error. Both predicates generated by has_profile therefore fail in this reduced SQL example.

Two independent changes to the identified-filter example were also executed locally:

  • Qualify the predicate as events.profile_id != events.device_id: exit code 0, output {"session_id":"s1","profile_id":"p1"}.
  • Keep the original predicate but rename the aggregate output to actor_profile_id: exit code 0, output {"session_id":"s1","actor_profile_id":"p1"}.

These results confirm the alias collision in the reduced SQL. Source inspection confirms the conflicting fragments in the funnel builder. They do not establish the exact error location or HTTP response for a complete application query, or validate a complete application fix.

Relevant source

Suggested fix and regression coverage

Apply the provided events qualifier to the input columns in the has_profile branch, or use a distinct aggregate output alias and update its references consistently.

Add regression coverage for session-grouped funnels with both has_profile values, including a database-backed execution test with prefer_column_name_to_alias = 0. Verify the funnel results as well as successful SQL execution, and preserve existing profile-grouped funnel behavior.

主要语言
TypeScript
星标
7.3k
派生
539
平均合并
1 天 20 小时
30 天内合并 PR
80

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

Openpanel-dev/openpanel 的其他 Issue

查看 Openpanel-dev/openpanel 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。