Conversion breakdowns drop every later day once the series limit is reached

未关闭
#655 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@officialasishkumar 已经在做这个了。

开始于 2026年11月7日。

  • #658 来自 @officialasishkumar —— 未关闭

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
typescript

调研方向

Start with packages/core/src/modules/chart/conversion.service.ts and inspect toSeries where the limit is checked before the breakdown key. Compare its behavior with funnel.service.ts, whose equivalent fix is described in the issue. Done means the limit caps the number of breakdown series while every kept series retains all days in the range; pull request #658 is already open.

由索引模型根据 Issue 内容生成。

描述

Description

A conversion chart with a breakdown loses data once the number of breakdown values reaches the report's limit. Every row after that point is dropped, including the later days of the series that were kept. Those lines stop early, and if the limit is reached on the first day, each series shows only that day. The summary and table built from the series are wrong in the same way.

The report editor sends limit: 500, so this happens with any breakdown that has at least 500 values over the range (paths, referrers, many custom properties). A smaller limit makes it happen sooner.

Root cause

toSeries in packages/core/src/modules/chart/conversion.service.ts checks the limit before it looks at the row's breakdown key:

if (limit && Object.keys(acc).length >= limit) {
  return acc;
}

The query orders rows by event_day, then by breakdown, so once the limit is reached, every later row is discarded, including rows of series that were already accepted.

The funnel's toSeries (funnel.service.ts) had the same bug and was fixed by checking the limit only for new keys. The conversion version never got that fix.

Expected behavior

The limit caps how many breakdown series come back. The series that are kept still have every day in the range.

主要语言
TypeScript
星标
7.3k
派生
539
平均合并
1 天 20 小时
30 天内合并 PR
80

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

Openpanel-dev/openpanel 的其他 Issue

查看 Openpanel-dev/openpanel 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。