Conversion breakdowns drop every later day once the series limit is reached
维护者通常 1 天内回复
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 停滞
- 技术栈
- typescript
调研方向
Start with packages/core/src/modules/chart/conversion.service.ts and inspect toSeries where the limit is checked before the breakdown key. Compare its behavior with funnel.service.ts, whose equivalent fix is described in the issue. Done means the limit caps the number of breakdown series while every kept series retains all days in the range; pull request #658 is already open.
由索引模型根据 Issue 内容生成。
描述
Description
A conversion chart with a breakdown loses data once the number of breakdown values reaches the report's limit. Every row after that point is dropped, including the later days of the series that were kept. Those lines stop early, and if the limit is reached on the first day, each series shows only that day. The summary and table built from the series are wrong in the same way.
The report editor sends limit: 500, so this happens with any breakdown that has at least 500 values over the range (paths, referrers, many custom properties). A smaller limit makes it happen sooner.
Root cause
toSeries in packages/core/src/modules/chart/conversion.service.ts checks the limit before it looks at the row's breakdown key:
if (limit && Object.keys(acc).length >= limit) {
return acc;
}
The query orders rows by event_day, then by breakdown, so once the limit is reached, every later row is discarded, including rows of series that were already accepted.
The funnel's toSeries (funnel.service.ts) had the same bug and was fixed by checking the limit only for new keys. The conversion version never got that fix.
Expected behavior
The limit caps how many breakdown series come back. The series that are kept still have every day in the range.
- 主要语言
- TypeScript
- 星标
- 7.3k
- 派生
- 539
- 平均合并
- 1 天 20 小时
- 30 天内合并 PR
- 80
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
Openpanel-dev/openpanel 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
Openpanel-dev/openpanel#653 · 1 个 reaction ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 73/100
Openpanel-dev/openpanel#610 · 1 条评论 ·
维护者通常 1 天内回复
-
Bug: Funnel has_profile filter conflicts with the profile_id aggregate alias (ClickHouse Code 184)未关闭
难度 3/5 1-2 天 新手友好度 76/100
Openpanel-dev/openpanel#663 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 68/100
Openpanel-dev/openpanel#661 ·
维护者通常 1 天内回复
-
Retention matrix drops cohorts where nobody did the return event可能已有人在做 @officialasishkumar 于 3 天前认领。 未关闭
难度 4/5 3-5 天 新手友好度 35/100
Openpanel-dev/openpanel#656 ·
维护者通常 1 天内回复
查看 Openpanel-dev/openpanel 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
duolicious/duolicious#1943 ·
维护者通常 1 天内回复
-
bug needs-triage
难度 2/5 1-3 小时 新手友好度 80/100
nightly-labs/openbot#6451 ·
维护者通常 1 天内回复
-
complexity: easy good first issue impact: low
难度 2/5 1-3 小时 新手友好度 72/100
ueberdosis/hocuspocus#1211 ·
维护者通常 1 天内回复
-
e2e-failure ready-to-code
难度 2/5 1-3 小时 新手友好度 64/100
redhat-developer/rhdh-plugin-export-overlays#4733 · 1 条评论 ·
维护者通常 1 天内回复
-
S-Needs triage
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 2 天内回复