Packaging: the two release lanes disagree on shipping the GPL license text — team decision needed
维护者通常 2 天内回复
已经有一个关联 PR 被合并了。
- #787 来自 @Amperstrand —— 已合并
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 25/100
- Issue 类型
- 功能
- 描述清晰度
- 需要澄清
- 活跃度
- 活跃
- 技术栈
- go
- 领域
- build-system
调研方向
Read packaging/local-build-ipk.sh and packaging/Makefile to verify the stated packaging difference. The issue explicitly leaves the policy choice to the team, so wait for a decision before changing either lane; done means implementing the chosen outcome and updating equivalence handling if needed.
由索引模型根据 Issue 内容生成。
描述
Migrated from Amperstrand/tollgate-module-basic-go#92 as part of the fork retirement — OpenTollGate/tollgate-module-basic-go is the single source of truth; the fork issue carries the original discussion and any lab evidence. Retirement plan: see the tracking issue linked in the migration comment there.]
Factual divergence (no recommendation attached — decision for the team)
Surfaces from the SDK-vs-SDK-free equivalence spike on main @ d0cb92f (context: upstream OpenTollGate#371, #383).
The two packaging lanes stage the license text differently:
| Lane | License handling |
|---|---|
SDK-free .ipk (packaging/local-build-ipk.sh) |
Installs the GPL-3.0 text into the payload as /usr/share/doc/tollgate-wrt/LICENSE |
SDK .apk (packaging/Makefile, the CI apk lane) |
Metadata only (PKG_LICENSE:=GPL-3.0-only, PKG_LICENSE_FILES:=LICENSE); no license text inside the package |
Consequences (why it needs an explicit decision rather than a silent fix):
- Content divergence between formats:
.ipkartifacts ship the license text;.apkartifacts built by CI do not. Same version, different contents. - Blocks byte-equivalence between the lanes — this single file (~35 KB GPL text) is the only content difference the spike found between the two staging lists (everything else matches).
- GPL-distribution relevance: shipping the text alongside the binary is the compliance-conservative direction; OpenWrt feed packages commonly rely on metadata instead. Both positions are defensible — this is precisely not a call for an agent to make.
Possible outcomes (listed neutrally):
- Add the install line to
packaging/Makefile→ both lanes ship it (.apkgrows ~35 KB) - Remove the install from
local-build-ipk.sh→ neither ships the text, metadata only - Keep as-is and document the divergence (equivalence tooling then treats it as a known, allowed delta)
Until decided, the equivalence tooling mirrors the SDK lane (the designated oracle) and reports this delta loudly with a link here.
- 主要语言
- Go
- 星标
- 12
- 派生
- 14
- 平均合并
- 4 天 19 小时
- 30 天内合并 PR
- 213
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
OpenTollGate/tollgate-module-basic-go 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 85/100
OpenTollGate/tollgate-module-basic-go#1159 ·
维护者通常 2 天内回复
-
Degraded-mode hygiene follow-ups: dead walletNotInitializedError() + main.go's startup log still over-promises mint recovery可能已有人在做 @Amperstrand 于 5 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
OpenTollGate/tollgate-module-basic-go#1135 · 1 条评论 ·
维护者通常 2 天内回复
-
setup_uhttpd_portal hardcodes the GUEST portal docroot to the TollGate path — the brand token cannot select a re-brand guest portal可能已有人在做 @Amperstrand 于 5 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
OpenTollGate/tollgate-module-basic-go#1122 ·
维护者通常 2 天内回复
-
changelog: dependency-security sweep missing from [Unreleased] [Amperstrand fork #105 review debt]未关闭
难度 1/5 1 小时以内 新手友好度 72/100
OpenTollGate/tollgate-module-basic-go#1055 · 1 条评论 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
OpenTollGate/tollgate-module-basic-go#1027 · 1 条评论 ·
维护者通常 2 天内回复
查看 OpenTollGate/tollgate-module-basic-go 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 77/100
JakeChampion/lang#14392 ·
维护者通常 1 天内回复
-
agent-butler-finding bug
难度 1/5 1-3 小时 新手友好度 84/100
jordansmall/spindrift#6557 ·
维护者通常 1 天内回复
-
[Bug] Custom tool truncation leaves unused stream copies open可能已有人在做 @OUAO-FRANK 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
[v3] KeyBindingManager calls (Add/Remove) are not converted into a case-insensitive accelerator.Key未关闭Bug
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 72/100
crmne/hyprmoncfg#114 · 1 条评论 ·
维护者通常 1 天内回复