Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Packaging: the two release lanes disagree on shipping the GPL license text — team decision needed

Cerrado
  • ¿Algo no está bien?
#751 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Ya se ha fusionado un pull request relacionado.

  • #787 de @Amperstrand — fusionado

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Necesita aclaración
Estado de actividad
Activo
Stack tecnológico
go
Área
build-system

Línea de trabajo

Read packaging/local-build-ipk.sh and packaging/Makefile to verify the stated packaging difference. The issue explicitly leaves the policy choice to the team, so wait for a decision before changing either lane; done means implementing the chosen outcome and updating equivalence handling if needed.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Migrated from Amperstrand/tollgate-module-basic-go#92 as part of the fork retirement — OpenTollGate/tollgate-module-basic-go is the single source of truth; the fork issue carries the original discussion and any lab evidence. Retirement plan: see the tracking issue linked in the migration comment there.]

Factual divergence (no recommendation attached — decision for the team)

Surfaces from the SDK-vs-SDK-free equivalence spike on main @ d0cb92f (context: upstream OpenTollGate#371, #383).

The two packaging lanes stage the license text differently:

Lane License handling
SDK-free .ipk (packaging/local-build-ipk.sh) Installs the GPL-3.0 text into the payload as /usr/share/doc/tollgate-wrt/LICENSE
SDK .apk (packaging/Makefile, the CI apk lane) Metadata only (PKG_LICENSE:=GPL-3.0-only, PKG_LICENSE_FILES:=LICENSE); no license text inside the package

Consequences (why it needs an explicit decision rather than a silent fix):

  1. Content divergence between formats: .ipk artifacts ship the license text; .apk artifacts built by CI do not. Same version, different contents.
  2. Blocks byte-equivalence between the lanes — this single file (~35 KB GPL text) is the only content difference the spike found between the two staging lists (everything else matches).
  3. GPL-distribution relevance: shipping the text alongside the binary is the compliance-conservative direction; OpenWrt feed packages commonly rely on metadata instead. Both positions are defensible — this is precisely not a call for an agent to make.

Possible outcomes (listed neutrally):

  • Add the install line to packaging/Makefile → both lanes ship it (.apk grows ~35 KB)
  • Remove the install from local-build-ipk.sh → neither ships the text, metadata only
  • Keep as-is and document the divergence (equivalence tooling then treats it as a known, allowed delta)

Until decided, the equivalence tooling mirrors the SDK lane (the designated oracle) and reports this delta loudly with a link here.

Lenguaje dominante
Go
Estrellas
12
Forks
14
Merge medio
1 d 5 h
PR fusionados (30 d)
220

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de OpenTollGate/tollgate-module-basic-go

Todos los issues de OpenTollGate/tollgate-module-basic-go

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.