Regression - Read noise floors from the case file at compare time

未关闭
#607 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 3 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
1-2 天
新手友好度
48/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
julia, sqlite
领域
testing

调研方向

Start by tracing compare_values and how the current CaseSpec is loaded, then inspect the SQLite cache code and the history and bisect comparison paths. Check existing tests for cached comparisons and threshold handling. Done means comparisons read floors from the current case file, cached runs store values without floors, and history and bisect results use consistent thresholds.

由索引模型根据 Issue 内容生成。

描述

The harness stores each quantity's noise_threshold with the run in the SQLite cache, and compare_values uses the first ref's stored floor.

  • Changing a threshold in a case TOML therefore has no effect on cached runs until they are rerun with --force (about 18 minutes per ref).
  • History and bisect reports can mix rows recorded before and after a threshold change, so the same quantity can show OK or CHANGED depending on which commit is "previous".

Proposal: treat the case file as the single source of truth. Read the floors from the current CaseSpec when comparing, and store only values in the cache. This also removes the need for a schema migration whenever a floor-like key is added.

主要语言
Julia
星标
11
派生
7
平均合并
4 天 1 小时
30 天内合并 PR
68

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

OpenFUSIONToolkit/GPEC 的其他 Issue

查看 OpenFUSIONToolkit/GPEC 的全部 Issue

相似的 Issue

更多 Julia Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。