fix(loader-server): a broken or looping symlink in the build folder crashes startup

未关闭
  • 哪里不对？
#146 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
68/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
bun, typescript
领域
backend, security

调研方向

Read apps/server/src/files.ts and apps/client/src/files.ts, starting with the getFiles and addPath functions cited in the report. Check how each handles symlinks, filesystem errors, and paths that resolve outside the build folder. Done means broken or cyclic links no longer crash startup or recurse indefinitely, and files outside the build folder are not listed or served.

由索引模型根据 Issue 内容生成。

描述

app:client app:server bug
Which app is this bug report for?

server

Issue description

Also affects client.

getFiles uses statSync, which follows symlinks, and catches nothing:

  • a dangling link throws ENOENT and the server loader dies at startup;
  • a link to a parent folder recurses until the stack overflows.

The client's addPath catches errors per entry but loops the same way on cyclic links. A symlink inside the build folder that points outside it is also served, because resolveInside only checks the path as a string.

Found by reading the code path (not reproduced).

Expected: symlinks don't crash the loader, and only files inside the build folder are listed and served.

Suggested fix: use lstat and skip symlinks (or resolve them with realpath and keep only targets inside the root), and catch errors per entry.

Found during a read-only audit of main @ 044c766 (2026-11-11).

Code sample
const addPath = (path: string, exportedPath: string) => {
  if (fs.statSync(path).isDirectory()) { // follows symlinks, throws on dangling ones
    for (const file of fs.readdirSync(path)) addPath(join(path, file), join(exportedPath, file));
    return;
  }
  paths.push([`/${exportedPath}`, path]);
};
Versions
  • @nanoforge-dev/loader-client / @nanoforge-dev/loader-server / @nanoforge-dev/loader-website 1.7.0 (main @ 044c766)
  • Bun 1.3.14
  • Linux x86_64
Issue priority

Low (slightly annoying)

I have tested this issue on a development release

044c766

主要语言
TypeScript
星标
1
派生
0
平均合并
17 小时 25 分钟
30 天内合并 PR
11

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

NanoForge-dev/Loader 的其他 Issue

查看 NanoForge-dev/Loader 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。