nf start, nf editor and nf dev exit 0 when the processes they start fail
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 72/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- bun, node.js, typescript
调研方向
Read src/lib/package-manager/package-manager.ts and the start, editor, and dev actions under src/action/actions/, then trace how AbstractAction.resolveResult handles keepAlive and failures. Check the existing tests for these actions and process management. Done means child failures stop the other processes, produce a failure message and nonzero exit, and the editor URL is printed only after /healthz responds.
由索引模型根据 Issue 内容生成。
描述
Which package is this bug report for?
@nanoforge-dev/cli
Which command is this bug report for?
start
Issue description
nf start, nf editor and nf dev exit with code 0 when the processes they start fail (read from the code, not run).
PackageManager.runandrunDevcatch a failed child and returnfalse(src/lib/package-manager/package-manager.ts#L97-L99, src/lib/package-manager/package-manager.ts#L143-L144).- The actions ignore that value (wrapped again in
runSafe) and always return{ keepAlive: true }(src/action/actions/start.action.ts#L88, src/action/actions/start.action.ts#L280-L281, src/action/actions/editor.action.ts#L38, src/action/actions/dev.action.ts#L21). AbstractAction.resolveResultreturns early onkeepAlive, so it neither prints the failure message nor callsprocess.exit(1). Once every child has exited, Node exits with 0.
Effects: a nf start whose loader can't bind its port or read its TLS files exits 0 in CI and in scripts. When only the client or only the server fails, the other one keeps running and the CLI only prints START_PART_FAILED. nf editor prints "Editor running!" (src/action/actions/editor.action.ts#L33) before the editor has started, and prints it even when the editor crashes.
Expected: when a child fails, the others are stopped and the command exits non-zero with its failure message. The editor URL is printed once /healthz answers.
Found during a read-only audit of main at e95b881 (2026-11-11).
Code sample
// start.action.ts
await Promise.all(tasks); // each task resolves even when its loader failed
return { keepAlive: true }; // -> resolveResult returns early, no exit code
Versions
- @nanoforge-dev/cli 3.0.1 (main, e95b881)
- Node.js 26.7.0
- Bun 1.3.14 (bundled)
- Linux
Issue priority
Medium (should be fixed soon)
I have tested this issue on a development release
No response
- 主要语言
- TypeScript
- 星标
- 2
- 派生
- 2
- 平均合并
- 2 天 18 小时
- 30 天内合并 PR
- 17
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
NanoForge-dev/CLI 的其他 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 88/100
NanoForge-dev/CLI#294 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
NanoForge-dev/CLI#293 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 76/100
NanoForge-dev/CLI#292 ·
维护者通常 1 天内回复
-
command:dev enhancement good first issue refactor
难度 2/5 1-3 小时 新手友好度 78/100
NanoForge-dev/CLI#281 ·
维护者通常 1 天内回复
-
bug command:build good first issue
难度 2/5 1-3 小时 新手友好度 88/100
NanoForge-dev/CLI#276 ·
维护者通常 1 天内回复
查看 NanoForge-dev/CLI 的全部 Issue
相似的 Issue
-
Mend: dependency security vulnerability
难度 1/5 1-3 小时 新手友好度 65/100
fdm-monster/fdm-monster#5563 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
be-BOP-io-SA/be-BOP#2849 ·
-
难度 2/5 1-3 小时 新手友好度 79/100
维护者通常 1 天内回复
-
1️⃣ phase/under-investigation flaky/confirmed flaky/needs-decision type/bug
难度 2/5 1-3 小时 新手友好度 65/100
growilabs/growi#12246 · 3 条评论 ·
维护者通常 1 天内回复
-
🐛 The Rulekeeper - An index run that gives up on the lock ends Succeeded可能已有人在做 @github-actions 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
SSWConsulting/SSW.Rules#2809 · 1 条评论 ·
维护者通常 1 天内回复