nf start, nf editor and nf dev exit 0 when the processes they start fail

Aperta
  • Qualcosa non va?
#277 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
bun, node.js, typescript
Ambito
backend, cli

Direzione di ricerca

Read src/lib/package-manager/package-manager.ts and the start, editor, and dev actions under src/action/actions/, then trace how AbstractAction.resolveResult handles keepAlive and failures. Check the existing tests for these actions and process management. Done means child failures stop the other processes, produce a failure message and nonzero exit, and the editor URL is printed only after /healthz responds.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug command:dev command:editor command:start
Which package is this bug report for?

@nanoforge-dev/cli

Which command is this bug report for?

start

Issue description

nf start, nf editor and nf dev exit with code 0 when the processes they start fail (read from the code, not run).

Effects: a nf start whose loader can't bind its port or read its TLS files exits 0 in CI and in scripts. When only the client or only the server fails, the other one keeps running and the CLI only prints START_PART_FAILED. nf editor prints "Editor running!" (src/action/actions/editor.action.ts#L33) before the editor has started, and prints it even when the editor crashes.

Expected: when a child fails, the others are stopped and the command exits non-zero with its failure message. The editor URL is printed once /healthz answers.

Found during a read-only audit of main at e95b881 (2026-11-11).

Code sample
// start.action.ts
await Promise.all(tasks);   // each task resolves even when its loader failed
return { keepAlive: true }; // -> resolveResult returns early, no exit code
Versions
  • @nanoforge-dev/cli 3.0.1 (main, e95b881)
  • Node.js 26.7.0
  • Bun 1.3.14 (bundled)
  • Linux
Issue priority

Medium (should be fixed soon)

I have tested this issue on a development release

No response

Lingua principale
TypeScript
Stelle
2
Fork
2
Merge medio
2g 18h
PR unite (30g)
17

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di NanoForge-dev/CLI

Tutte le issue di NanoForge-dev/CLI

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.