Include java-build in the PR test summary

未关闭
  • 哪里不对？
#1,824 1 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 1 天内回复

@hlinsen 已经在做这个了。

开始于 2026年8月28日。

评估

这个 Issue 还没有评估数据。

描述

The "PR test summary (non-blocking)" job (ci/utils/pr_test_summary.py, wired up in .github/workflows/pr.yaml) only depends on and reports conda-cpp-tests, conda-python-tests, wheel-tests-cuopt, wheel-tests-cuopt-server, and test-self-hosted-server (_TEST_PREFIXES in the script, and the pr-test-summary job's needs: list). java-build isn't included, so it neither gates the summary nor shows up in it — the summary can post "all tests passed" while java-build is still running or has failed.

Possible fix

  • Add java-build to pr-test-summary's needs: list in .github/workflows/pr.yaml
  • Add a matching prefix to _TEST_PREFIXES in ci/utils/pr_test_summary.py
  • Note: _analyze_job_log only parses gtest ([ FAILED ]) and pytest (short test summary info) failure formats. A failed java-build job would still show up correctly as a failed job in the top-line counts, just without a per-test breakdown (JUnit/Surefire output isn't parsed) — that's an acceptable degrade, not a blocker, unless we also want per-test Java failures listed.

Context

Noticed while investigating #1820 / #1823: PR #1823's "PR test summary (non-blocking)" check passed while java-build / build was still in progress, which was confusing to reviewers since it looked like the whole PR was green.

主要语言
Cuda
星标
1.1k
派生
255
平均合并
1 天 11 小时
30 天内合并 PR
123

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

NVIDIA/cuopt 的其他 Issue

查看 NVIDIA/cuopt 的全部 Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。