Include java-build in the PR test summary

Abierto
#1,824 1 comentario 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@hlinsen ya está trabajando en esto.

Desde el 28/8/2026.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

The "PR test summary (non-blocking)" job (ci/utils/pr_test_summary.py, wired up in .github/workflows/pr.yaml) only depends on and reports conda-cpp-tests, conda-python-tests, wheel-tests-cuopt, wheel-tests-cuopt-server, and test-self-hosted-server (_TEST_PREFIXES in the script, and the pr-test-summary job's needs: list). java-build isn't included, so it neither gates the summary nor shows up in it — the summary can post "all tests passed" while java-build is still running or has failed.

Possible fix

  • Add java-build to pr-test-summary's needs: list in .github/workflows/pr.yaml
  • Add a matching prefix to _TEST_PREFIXES in ci/utils/pr_test_summary.py
  • Note: _analyze_job_log only parses gtest ([ FAILED ]) and pytest (short test summary info) failure formats. A failed java-build job would still show up correctly as a failed job in the top-line counts, just without a per-test breakdown (JUnit/Surefire output isn't parsed) — that's an acceptable degrade, not a blocker, unless we also want per-test Java failures listed.

Context

Noticed while investigating #1820 / #1823: PR #1823's "PR test summary (non-blocking)" check passed while java-build / build was still in progress, which was confusing to reviewers since it looked like the whole PR was green.

Lenguaje dominante
Cuda
Estrellas
1.1k
Forks
249
Merge medio
1 d 15 h
PR fusionados (30 d)
126

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de NVIDIA/cuopt

Todos los issues de NVIDIA/cuopt

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.