Embedding strict calls: no test cell makes a call on an attached state while a second state is parked on the thread

未关闭
#2,465 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
50/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
c
领域
testing

调研方向

Read tests/test_embed_strict_calls.c, tools/embed_strict_variants.py, and the row h entry in issue #2439, then inspect the suite's four environments. Add matrix kinds for both parked-state setups, check each cell's expected values and that switching back reads the parked state unchanged, and add the three variants so each fails on a new cell after its clean control. Update the expected matrix count and row h's scope; done when the four-environment suite passes.

由索引模型根据 Issue 内容生成。

描述

area:embed kind:gate-defect

The test program of the embedding strict calls (tests/test_embed_strict_calls.c, #2460) checks every cell of call, kind of state, start position and value. Its kind other holds the sentence "Changing one state does not affect any other state" in one setup: the call is made on a state from eigs_state_new that is not attached, while the other state is the thread's current attachment. It does not run a call on a state that is itself attached while a second state is parked on the thread (the embedding API keeps a parked attachment alive across eigs_thread_switch).

An independent review of #2460 built a wrong variant in that gap: the guards call, when the state it is given is attached, also writes every other attached state (it walks the state registry). The whole program stays green with it in all four environments. The review's own witness program, on that variant:

FAIL: S1 guards value=1 self=1,0 (want 1,0) other=1,0 (want 0,0)
...
witness-h: FAIL failures=8

and on the unchanged code witness-h: PASS failures=0. Its two setups:

  • S1: the called state comes from eigs_open; the other is made, switched to, initialised, and left parked.
  • S2: the called state is called after eigs_thread_switch and before eigs_state_init_runtime, while the other (from eigs_open) is parked.

The three calls themselves are one line each and write only the state they are given, so nothing is wrong with the runtime. The gap is in what the test holds, and the closed list of #2439 says so since 2026-11-21 (its row h is bounded to the one setup the kind other runs).

Done when

  • The matrix has the two setups as kinds of their own (a call on a state from eigs_open while a second, initialised state is parked on the thread; a call between attach and initialisation while a second state is parked), every cell expected from its inputs alone, and the parked state read back unchanged after a switch to it.
  • tools/embed_strict_variants.py has, for each of the three calls, the variant that writes every other attached state when the called state is attached, each red by a cell of the new kinds, after the tool's clean control.
  • The suite section's expected matrix line follows the new cell count, and the section passes in its four environments.
  • Row h of #2439's closed list (the documents' sentence on other states) is widened back to cover the new kinds, and its "Not claimed" line for these setups is taken out.

Refs #2439, #2460.

— Claude DevBox

主要语言
C
星标
3
派生
7
平均合并
3 小时 28 分钟
30 天内合并 PR
270

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

InauguralSystems/EigenScript 的其他 Issue

查看 InauguralSystems/EigenScript 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。