Embedding strict calls: no test cell makes a call on an attached state while a second state is parked on the thread

Aberta
#2,465 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
50/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
c
Domínio
testing

Direção de pesquisa

Read tests/test_embed_strict_calls.c, tools/embed_strict_variants.py, and the row h entry in issue #2439, then inspect the suite's four environments. Add matrix kinds for both parked-state setups, check each cell's expected values and that switching back reads the parked state unchanged, and add the three variants so each fails on a new cell after its clean control. Update the expected matrix count and row h's scope; done when the four-environment suite passes.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

area:embed kind:gate-defect

The test program of the embedding strict calls (tests/test_embed_strict_calls.c, #2460) checks every cell of call, kind of state, start position and value. Its kind other holds the sentence "Changing one state does not affect any other state" in one setup: the call is made on a state from eigs_state_new that is not attached, while the other state is the thread's current attachment. It does not run a call on a state that is itself attached while a second state is parked on the thread (the embedding API keeps a parked attachment alive across eigs_thread_switch).

An independent review of #2460 built a wrong variant in that gap: the guards call, when the state it is given is attached, also writes every other attached state (it walks the state registry). The whole program stays green with it in all four environments. The review's own witness program, on that variant:

FAIL: S1 guards value=1 self=1,0 (want 1,0) other=1,0 (want 0,0)
...
witness-h: FAIL failures=8

and on the unchanged code witness-h: PASS failures=0. Its two setups:

  • S1: the called state comes from eigs_open; the other is made, switched to, initialised, and left parked.
  • S2: the called state is called after eigs_thread_switch and before eigs_state_init_runtime, while the other (from eigs_open) is parked.

The three calls themselves are one line each and write only the state they are given, so nothing is wrong with the runtime. The gap is in what the test holds, and the closed list of #2439 says so since 2026-11-21 (its row h is bounded to the one setup the kind other runs).

Done when

  • The matrix has the two setups as kinds of their own (a call on a state from eigs_open while a second, initialised state is parked on the thread; a call between attach and initialisation while a second state is parked), every cell expected from its inputs alone, and the parked state read back unchanged after a switch to it.
  • tools/embed_strict_variants.py has, for each of the three calls, the variant that writes every other attached state when the called state is attached, each red by a cell of the new kinds, after the tool's clean control.
  • The suite section's expected matrix line follows the new cell count, and the section passes in its four environments.
  • Row h of #2439's closed list (the documents' sentence on other states) is widened back to cover the new kinds, and its "Not claimed" line for these setups is taken out.

Refs #2439, #2460.

— Claude DevBox

Linguagem predominante
C
Estrelas
3
Forks
7
Merge médio
3h 28min
PRs com merge (30d)
270

Preparar o ambiente

Abrir no Codespaces

Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de InauguralSystems/EigenScript

Todas as issues de InauguralSystems/EigenScript

Issues semelhantes

Mais issues de C

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.