`http_fetch`: no row sends a request through a proxy

未关闭
#2,395 4 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
54/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
c, python

调研方向

Start with tests/test_http_fetch.py and the implementation of http_fetch and http_post, then compare proxy behavior with what the curl library does directly. Add coverage for HTTP proxy requests and HTTPS CONNECT responses, including status, headers, body, and header line limits; decide whether to retain Proxy-Connection: Keep-Alive and document it in docs/BUILTINS.md if retained. Done when the proxy tests pass on each library release used by the gates.

由索引模型根据 Issue 内容生成。

描述

area:gates area:http kind:gate-defect

The bar of #2375 says that the curl library's own handling of the proxy variables applies to http_fetch and http_post. Three of its sentences stand on that path: a request that goes through a proxy "is written the way the library writes it for a proxy"; the lines of a proxy's answer to CONNECT count against the limit on answer header lines; and that answer is not the final response. Every row of tests/test_http_fetch.py runs with the proxy variables unset, so no test runs any of the three.

Run by hand through the library alone, with a proxy on a raw socket that answers CONNECT with HTTP/1.1 200 Connection established and X-P: 1 (2026-11-17, curl 8.5.0, 8.14.1 and 8.18.0, the same on each):

code=0   b'HTTP/1.1 200 Connection established\r\n'
code=0   b'X-P: 1\r\n'
code=0   b'\r\n'
code=404 b'HTTP/1.1 404 Not Found\r\n'
code=404 b'X-A: 1\r\n'
...

So the library hands the lines of the proxy's answer to the same header callback as every other header line, and reports the response code 0 for them (CURLINFO_RESPONSE_CODE); the origin's code comes only with the origin's lines. Through a proxy the library also writes a Proxy-Connection: Keep-Alive of its own.

Done when

  • A row sends an http:// request through a listener named in http_proxy and checks what the proxy receives against what the library writes for a proxy (asked of the library directly).
  • A row sends an https:// request through a listener that answers CONNECT with header lines of its own: the program gets the origin's answer (status, headers, body), none of the proxy's lines is among its headers, and the proxy's lines count against the limit on answer header lines.
  • A decision says what an http:// request through a proxy carries besides Connection: close: the library's Proxy-Connection: Keep-Alive taken out, or left and docs/BUILTINS.md says so (run on 2026-11-17: both lines go out today, see the comment below). The row of the first item checks the decided lines.
  • Both run on each release of the library that the gates use.

— Claude DevBox

主要语言
C
星标
3
派生
7
平均合并
3 小时 28 分钟
30 天内合并 PR
270

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

InauguralSystems/EigenScript 的其他 Issue

查看 InauguralSystems/EigenScript 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。