`http_fetch`: no row sends a request through a proxy

オープン
#2,395 コメント 4 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
54/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
c, python

調査の方向性

Start with tests/test_http_fetch.py and the implementation of http_fetch and http_post, then compare proxy behavior with what the curl library does directly. Add coverage for HTTP proxy requests and HTTPS CONNECT responses, including status, headers, body, and header line limits; decide whether to retain Proxy-Connection: Keep-Alive and document it in docs/BUILTINS.md if retained. Done when the proxy tests pass on each library release used by the gates.

索引モデルが issue の本文から書いたものです。

説明

area:gates area:http kind:gate-defect

The bar of #2375 says that the curl library's own handling of the proxy variables applies to http_fetch and http_post. Three of its sentences stand on that path: a request that goes through a proxy "is written the way the library writes it for a proxy"; the lines of a proxy's answer to CONNECT count against the limit on answer header lines; and that answer is not the final response. Every row of tests/test_http_fetch.py runs with the proxy variables unset, so no test runs any of the three.

Run by hand through the library alone, with a proxy on a raw socket that answers CONNECT with HTTP/1.1 200 Connection established and X-P: 1 (2026-11-17, curl 8.5.0, 8.14.1 and 8.18.0, the same on each):

code=0   b'HTTP/1.1 200 Connection established\r\n'
code=0   b'X-P: 1\r\n'
code=0   b'\r\n'
code=404 b'HTTP/1.1 404 Not Found\r\n'
code=404 b'X-A: 1\r\n'
...

So the library hands the lines of the proxy's answer to the same header callback as every other header line, and reports the response code 0 for them (CURLINFO_RESPONSE_CODE); the origin's code comes only with the origin's lines. Through a proxy the library also writes a Proxy-Connection: Keep-Alive of its own.

Done when

  • A row sends an http:// request through a listener named in http_proxy and checks what the proxy receives against what the library writes for a proxy (asked of the library directly).
  • A row sends an https:// request through a listener that answers CONNECT with header lines of its own: the program gets the origin's answer (status, headers, body), none of the proxy's lines is among its headers, and the proxy's lines count against the limit on answer header lines.
  • A decision says what an http:// request through a proxy carries besides Connection: close: the library's Proxy-Connection: Keep-Alive taken out, or left and docs/BUILTINS.md says so (run on 2026-11-17: both lines go out today, see the comment below). The row of the first item checks the decided lines.
  • Both run on each release of the library that the gates use.

— Claude DevBox

主要言語
C
スター
3
フォーク
7
平均マージ
3時間 28分
マージ済み PR(30日)
270

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

InauguralSystems/EigenScript のほかの issue

InauguralSystems/EigenScript の issue をすべて見る

似ている issue

C の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。