eigenlsp: scopes past MAX_FN_SCOPES (256) are silently dropped; rename then edits shadowed locals
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start in build_scopes in src/eigenlsp.c and trace how the scope count is returned and consumed by rename resolution. Add a regression test with more than 256 scopes, then run the rename path and execute the renamed program. Done means scope handling no longer silently loses late scopes and a late same-named parameter remains untouched.
由索引模型根据 Issue 内容生成。
描述
Found by /code-review on PR #1330. The limit itself predates that PR, but #1330 makes it bite sooner.
build_scopes in src/eigenlsp.c stops recording scopes after MAX_FN_SCOPES (256), with no warning; the returned count is simply lower. #1330 gives each lambda a scope too, so lambdas now use slots from the same budget as define and for.
In a file with ~200 defines and ~60 early lambdas, the later defines get no scope. Renaming a global x then also rewrites a later define g(x): signature and body, and a later local x resolves to the global. That is a silent wrong edit.
Done when
- The scope table grows as needed (no fixed cap), or rename refuses with an error when the limit is reached rather than guessing.
- A test: a file with more than 256 scopes, where a rename of a global leaves a late
define's same-named parameter untouched (checked by running the renamed program).
- 主要语言
- C
- 星标
- 3
- 派生
- 7
- 平均合并
- 3 小时 58 分钟
- 30 天内合并 PR
- 105
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
InauguralSystems/EigenScript 的其他 Issue
-
area:lint-tooling bug
难度 2/5 1-3 小时 新手友好度 88/100
InauguralSystems/EigenScript#1340 ·
维护者通常 1 天内回复
-
area:stdlib found-by:code-review kind:silent-wrong
难度 2/5 1-3 小时 新手友好度 88/100
InauguralSystems/EigenScript#1338 ·
维护者通常 1 天内回复
-
area:lint-tooling found-by:critic kind:docs-drift
难度 2/5 1-3 小时 新手友好度 76/100
InauguralSystems/EigenScript#1335 ·
维护者通常 1 天内回复
-
area:ci found-by:critic kind:gate-defect
难度 2/5 1-3 小时 新手友好度 86/100
InauguralSystems/EigenScript#1311 ·
维护者通常 1 天内回复
-
enrolment: decide test_gc_runner_controls.py (exempt vs enrol) and whether floors need a ratchet未关闭area:gates found-by:critic kind:decision
难度 2/5 1-3 小时 新手友好度 65/100
InauguralSystems/EigenScript#1280 · 1 条评论 ·
维护者通常 1 天内回复
查看 InauguralSystems/EigenScript 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 76/100
johnsonjh/emu2-cpm86#68 · 1 条评论 ·
维护者通常 1 天内回复
-
Zenmap Crash未关闭Zenmap
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
BasedHardware/omi#19306 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 88/100
fastfetch-cli/fastfetch#2619 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100