Type the webhook payload as a `WebhookPayload` TypedDict so unknown or mistyped keys are caught statically
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start in forgelm/webhook.py, at _send, where payload: Dict[str, Any] is built and the runtime allowlist is applied. Read the roadmap entry at docs/roadmap/phase-14-5-pipeline-hardening.md line 132 for the intended scope. Done means a WebhookPayload TypedDict with base keys and NotRequired event keys types the payload, and a type check covers the file. That check depends on a mypy gate that the issue links to but does not yet exist, so confirm with maintainers first.
由索引模型根据 Issue 内容生成。
描述
Deferred work ·
Phase 14.5: WebhookPayload TypedDict· severity Low · cost ~1-2 h · recorded indocs/roadmap/phase-14-5-pipeline-hardening.md:132
Summary
Phase 14.5 Task 4 replaced the free-form merge in _send(**extra) with a runtime allowlist plus scalar-type and base-field-collision screens; its optional follow-up — a typed WebhookPayload so a type checker flags unknown keys at edit time — was never built and is listed nowhere else. Low priority: the runtime allowlist already drops unregistered keys.
Condition or budget
None recorded ("Optional follow-up").
State today (re-checked 2026-10-09)
_send still builds payload: Dict[str, Any]; no TypedDict exists for it.
Related
It is only enforced if forgelm/webhook.py comes under a mypy gate (see the [tool.mypy] issue).
Acceptance criteria
-
WebhookPayload(base keys plusNotRequiredevent-specific keys) types the payload, and a type check coversforgelm/webhook.py.
Recorded in docs/roadmap/phase-14-5-pipeline-hardening.md (read at f94595f) and re-checked against the code on 2026-10-09.
- 主要语言
- Python
- 星标
- 9
- 派生
- 1
- 平均合并
- 8 小时 50 分钟
- 30 天内合并 PR
- 45
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
HodeTech/ForgeLM 的其他 Issue
-
area: site bug good first issue severity: low wave: 4
难度 2/5 1-3 小时 新手友好度 75/100
HodeTech/ForgeLM#961 · 1 条评论 ·
维护者通常 1 天内回复
-
area: dev-tooling bug severity: low source: roadmap wave: 4
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
-
Trend-tracking jq recipe prints evaluation_completed=false as 'n/a', because jq's // operator treats false like null (F-W1-DOCS-TRAIN-16)可能已有人在做 @yuefdev 于 3 天前认领。 未关闭documentation good first issue severity: low source: review-2026-09 wave: 4
难度 1/5 1-3 小时 新手友好度 80/100
维护者通常 1 天内回复
-
documentation severity: medium source: review-2026-09 wave: 3
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
documentation good first issue severity: medium source: review-2026-09 wave: 3
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
相似的 Issue
-
documentation good first issue
难度 2/5 1-3 小时 新手友好度 82/100
selimfirat/pysad#379 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 75/100
open-webui/open-webui#32805 ·
维护者通常 1 天内回复
-
fix: [bug description] HTML CVE metric table shows only the last CVE for each product可能已有人在做 @Chris-wh233 今天认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 66/100
ossf/cve-bin-tool#5976 ·
维护者通常 1 天内回复
-
needs-triage
难度 2/5 1-3 小时 新手友好度 72/100
gke-labs/kube-agents#3615 ·
维护者通常 1 天内回复
-
deferred
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复