Type the webhook payload as a `WebhookPayload` TypedDict so unknown or mistyped keys are caught statically
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-3 horas
- Aptitud para principiantes
- 42/100
Línea de trabajo
Start in forgelm/webhook.py, at _send, where payload: Dict[str, Any] is built and the runtime allowlist is applied. Read the roadmap entry at docs/roadmap/phase-14-5-pipeline-hardening.md line 132 for the intended scope. Done means a WebhookPayload TypedDict with base keys and NotRequired event keys types the payload, and a type check covers the file. That check depends on a mypy gate that the issue links to but does not yet exist, so confirm with maintainers first.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Deferred work ·
Phase 14.5: WebhookPayload TypedDict· severity Low · cost ~1-2 h · recorded indocs/roadmap/phase-14-5-pipeline-hardening.md:132
Summary
Phase 14.5 Task 4 replaced the free-form merge in _send(**extra) with a runtime allowlist plus scalar-type and base-field-collision screens; its optional follow-up — a typed WebhookPayload so a type checker flags unknown keys at edit time — was never built and is listed nowhere else. Low priority: the runtime allowlist already drops unregistered keys.
Condition or budget
None recorded ("Optional follow-up").
State today (re-checked 2026-10-09)
_send still builds payload: Dict[str, Any]; no TypedDict exists for it.
Related
It is only enforced if forgelm/webhook.py comes under a mypy gate (see the [tool.mypy] issue).
Acceptance criteria
-
WebhookPayload(base keys plusNotRequiredevent-specific keys) types the payload, and a type check coversforgelm/webhook.py.
Recorded in docs/roadmap/phase-14-5-pipeline-hardening.md (read at f94595f) and re-checked against the code on 2026-10-09.
- Lenguaje dominante
- Python
- Estrellas
- 9
- Forks
- 1
- Merge medio
- 8 h 10 min
- PR fusionados (30 d)
- 5
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de HodeTech/ForgeLM
-
area: dev-tooling bug severity: low source: roadmap wave: 4
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
area: site bug good first issue severity: low source: review-2026-09 wave: 4
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
-
documentation good first issue severity: medium source: review-2026-09 wave: 3
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
documentation good first issue severity: low source: review-2026-09 wave: 4
Dificultad 1/5 1-3 horas Aptitud para principiantes 80/100
-
documentation severity: medium source: review-2026-09 wave: 3
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Todos los issues de HodeTech/ForgeLM
Issues similares
-
enhancement from-review
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
khuisman/mcp-gee-sweet#1010 ·
Los mantenedores suelen responder en 1 día
-
bug confirmed issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
open-webui/open-webui#32333 · 2 comentarios ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
ll7/robot_sf_ll7#10368 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
-
mcp: a write that loses its answer is reported as "cannot reach", although it may have landedAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
flop-labs/technocore-chat#982 ·
Los mantenedores suelen responder en 1 día