Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Decide what `tests/runtime_smoke.py` is: pytest never collects it, it writes `tmp_smoke_test/` into the cwd, and `testing.md` misdescribes it

未关闭
#912 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
半天
新手友好度
30/100
Issue 类型
重构
描述清晰度
基本清楚
活跃度
活跃
技术栈
huggingface, python
领域
testing

调研方向

Start with tests/runtime_smoke.py, pyproject.toml (the testpaths setting that keeps pytest from collecting it), and the testing.md description. Choose one of the three recorded options (delete, move to tools/, or rename with mocked loading), since the issue does not decide it. Done means no uncollected script remains under tests/, nothing writes to tmp_smoke_test/ in the cwd, the docs match the code, and the deferral row and CHANGELOG cite F-PR29-A4-05.

由索引模型根据 Issue 内容生成。

描述

area: dev-tooling severity: low source: roadmap wave: 4

Deferred work · F-PR29-A4-05 · severity Low · cost ~1 h · recorded in docs/roadmap/risks-and-decisions.md:83

Summary

tests/runtime_smoke.py is the only script that runs a real one-step training (SmolLM2-135M), but its name keeps pytest from collecting it, so it never runs. It writes into ./tmp_smoke_test with the cleanup commented out, carries Turkish comments, and testing.md presents it as a dry-run fixture. Options recorded at PR #29: move it to tools/manual_smoke.py as a documented release gate, or rename it with mocked model loading and tmp_path; folding it into the nightly smoke #106 asks for is a third.

Condition or budget

None recorded (the row still names v0.6.x).

State today (re-checked 2026-10-09)

The file is unchanged since 2026-04-26; pyproject.toml sets only testpaths, so it is not collected.

Related

#106 (CR-A16-022) asks for an unmocked nightly smoke per trainer_type; it names this file but not its disposition.

Acceptance criteria

  • The file is deleted, folded into the nightly smoke, or moved to tools/ as a documented release-gate check — no uncollected script is left under tests/.
  • Nothing writes into the working directory, comments are English, and testing.md describes what exists.
  • The row is removed from the deferral table and the CHANGELOG names its ID (the table's removal contract).

Recorded in docs/roadmap/risks-and-decisions.md (read at f94595f) and re-checked against the code on 2026-10-09. The row leaves that table only when the fix is on main, the CHANGELOG names its ID and any promised guard exists.

主要语言
Python
星标
9
派生
1
平均合并
8 小时 50 分钟
30 天内合并 PR
45

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

HodeTech/ForgeLM 的其他 Issue

查看 HodeTech/ForgeLM 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。