Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Decide what `tests/runtime_smoke.py` is: pytest never collects it, it writes `tmp_smoke_test/` into the cwd, and `testing.md` misdescribes it

Aperta
  • Qualcosa non va?
#912 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
30/100
Tipo di issue
Refactoring
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
huggingface, python
Ambito
testing

Direzione di ricerca

Start with tests/runtime_smoke.py, pyproject.toml (the testpaths setting that keeps pytest from collecting it), and the testing.md description. Choose one of the three recorded options (delete, move to tools/, or rename with mocked loading), since the issue does not decide it. Done means no uncollected script remains under tests/, nothing writes to tmp_smoke_test/ in the cwd, the docs match the code, and the deferral row and CHANGELOG cite F-PR29-A4-05.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: dev-tooling severity: low source: roadmap wave: 4

Deferred work · F-PR29-A4-05 · severity Low · cost ~1 h · recorded in docs/roadmap/risks-and-decisions.md:83

Summary

tests/runtime_smoke.py is the only script that runs a real one-step training (SmolLM2-135M), but its name keeps pytest from collecting it, so it never runs. It writes into ./tmp_smoke_test with the cleanup commented out, carries Turkish comments, and testing.md presents it as a dry-run fixture. Options recorded at PR #29: move it to tools/manual_smoke.py as a documented release gate, or rename it with mocked model loading and tmp_path; folding it into the nightly smoke #106 asks for is a third.

Condition or budget

None recorded (the row still names v0.6.x).

State today (re-checked 2026-10-09)

The file is unchanged since 2026-04-26; pyproject.toml sets only testpaths, so it is not collected.

Related

#106 (CR-A16-022) asks for an unmocked nightly smoke per trainer_type; it names this file but not its disposition.

Acceptance criteria

  • The file is deleted, folded into the nightly smoke, or moved to tools/ as a documented release-gate check — no uncollected script is left under tests/.
  • Nothing writes into the working directory, comments are English, and testing.md describes what exists.
  • The row is removed from the deferral table and the CHANGELOG names its ID (the table's removal contract).

Recorded in docs/roadmap/risks-and-decisions.md (read at f94595f) and re-checked against the code on 2026-10-09. The row leaves that table only when the fix is on main, the CHANGELOG names its ID and any promised guard exists.

Lingua principale
Python
Stelle
9
Fork
1
Merge medio
8h 10m
PR unite (30g)
5

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di HodeTech/ForgeLM

Tutte le issue di HodeTech/ForgeLM

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.