Signing out of one instance keeps its cached queries for the next sign-in

未关闭 适合新手
  • 哪里不对？
#1,993 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
77/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript
领域
authentication, frontend

调研方向

Start with src/features/auth/store/authStore.ts and src/features/cluster/signOutOfInstance.ts, then compare how full sign-out clears the cache in src/features/auth/handlers/clearAuthStateLocally.ts. Check the instance query key pattern, such as [<id>, 'get_components'], and consider reads already in flight. Done means per-instance sign-out drops that instance’s cached queries; verify the CLI import no longer receives stale results.

由索引模型根据 Issue 内容生成。

描述

Signing out of a single instance clears its credentials but not its cached data. authStore.signOutLocally (src/features/auth/store/authStore.ts:779-783), which the per-instance sign-outs call, clears the sign-in and its flags but never touches the query cache, and signOutOfInstance (src/features/cluster/signOutOfInstance.ts:13-26) adds nothing that does. Only the full sign-outs clear the cache (src/features/auth/handlers/clearAuthStateLocally.ts:15 and :25).

So after a per-instance sign-out, in the same tab:

  • The instance's queries, keyed by its id (for example [<id>, 'get_components']), stay cached. A later sign-in to that instance starts from the previous session's results until each query refetches.
  • A read started before the sign-out still completes into that cache and resolves to its caller. reloadRootEntries is one: its sign-out guard from #1987 only refuses a reload called after the sign-out, so a CLI import already waiting on it (src/features/instance/applications/components/NewApplication/useCheckCLI.ts:27-33) still gets the old tree and sets focus and selection from it.

Found by code reading while reviewing #1987.

Fix direction: drop the instance's queries, which also takes its in-flight reads out of the cache, wherever a per-instance sign-out runs, the way the full sign-out clears the whole cache.

Review-Deferral: abdc32183bb41ec9 severity=nit category=correctness

🤖 Generated by Claude Code (Claude Opus 5.5); posted via @dawsontoth.

主要语言
TypeScript
星标
5
派生
4
平均合并
1 天 20 小时
30 天内合并 PR
140

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

HarperFast/studio 的其他 Issue

查看 HarperFast/studio 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。