Signing out of one instance keeps its cached queries for the next sign-in

Aperta Adatta ai principianti
  • Qualcosa non va?
#1,993 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
77/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
authentication, frontend

Direzione di ricerca

Start with src/features/auth/store/authStore.ts and src/features/cluster/signOutOfInstance.ts, then compare how full sign-out clears the cache in src/features/auth/handlers/clearAuthStateLocally.ts. Check the instance query key pattern, such as [<id>, 'get_components'], and consider reads already in flight. Done means per-instance sign-out drops that instance’s cached queries; verify the CLI import no longer receives stale results.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Signing out of a single instance clears its credentials but not its cached data. authStore.signOutLocally (src/features/auth/store/authStore.ts:779-783), which the per-instance sign-outs call, clears the sign-in and its flags but never touches the query cache, and signOutOfInstance (src/features/cluster/signOutOfInstance.ts:13-26) adds nothing that does. Only the full sign-outs clear the cache (src/features/auth/handlers/clearAuthStateLocally.ts:15 and :25).

So after a per-instance sign-out, in the same tab:

  • The instance's queries, keyed by its id (for example [<id>, 'get_components']), stay cached. A later sign-in to that instance starts from the previous session's results until each query refetches.
  • A read started before the sign-out still completes into that cache and resolves to its caller. reloadRootEntries is one: its sign-out guard from #1987 only refuses a reload called after the sign-out, so a CLI import already waiting on it (src/features/instance/applications/components/NewApplication/useCheckCLI.ts:27-33) still gets the old tree and sets focus and selection from it.

Found by code reading while reviewing #1987.

Fix direction: drop the instance's queries, which also takes its in-flight reads out of the cache, wherever a per-instance sign-out runs, the way the full sign-out clears the whole cache.

Review-Deferral: abdc32183bb41ec9 severity=nit category=correctness

🤖 Generated by Claude Code (Claude Opus 5.5); posted via @dawsontoth.

Lingua principale
TypeScript
Stelle
5
Fork
4
Merge medio
1g 20h
PR unite (30g)
140

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di HarperFast/studio

Tutte le issue di HarperFast/studio

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.