Sensor ack packets for DisablePiezo/GetHeaterOffset/ClearAlarm (0xA9/0xAA/0xAD) are not decoded

未关闭
  • 哪里不对？
#44 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
冷清
技术栈
rust
领域
backend, embedded-iot

调研方向

Read crates/pod-proto/src/sensor/command.rs and the SensorPacket::parse match in crates/pod-proto/src/sensor/packet.rs to understand the command and packet types. Check how other sensor acknowledgements are decoded, then run the relevant codec or packet tests if available. Done means acknowledgements for 0xA9 and 0xAA decode instead of reaching Unexpected; confirm ClearAlarm's opcode and payload before including it.

由索引模型根据 Issue 内容生成。

描述

enhancement

The three // TODO add resp packet + 0x80 markers in crates/pod-proto/src/sensor/command.rs:21,28,32 sit on DisablePiezo (0x29), GetHeaterOffset (0x2A), and ClearAlarm (0x2D). SensorPacket::parse (crates/pod-proto/src/sensor/packet.rs:135-160) has no arm for their acknowledgements (0xA9/0xAA/0xAD), so sending any of these would make the reply fall to the _ => Unexpected branch, which the codec logs as an error (codec.rs:85). All three commands are currently #[allow(dead_code)] and unused, so this only bites once they're wired up. ClearAlarm is additionally flagged UNVERIFIED / 'seems to be crashing the mcu' (command.rs:29), so its opcode/payload needs confirming before use.

Filed from a repo-wide code audit (working tree at bcad746).

主要语言
Rust
星标
0
派生
0
30 天内没有已合并 PR

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

GoogleBot42/podd 的其他 Issue

查看 GoogleBot42/podd 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。