aeskey and jwt Secrets are missing helm.sh/resource-policy: keep
还没有人认领这个 Issue。
评估
- 难度
- 1/5
- 预计耗时
- 1 小时以内
- 新手友好度
- 88/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- helm, typescript
- 领域
- devops
调研方向
将 .helm/ctrl/templates/secrets/aeskey.yaml 和 jwt.yaml 与已包含 keep 注解的 postgres.yaml 进行比较。为这两个 Secrets 添加相同的元数据注解；然后检查渲染后的 Helm 模板，确认该注解存在。完成的标准是卸载 release 后，AES 密钥和 JWT Secrets 仍会保留。
由索引模型根据 Issue 内容生成。
描述
The ctrl-postgres Secret in .helm/ctrl/templates/secrets/postgres.yaml carries "helm.sh/resource-policy": keep. The aeskey and jwt Secrets don't, and never have, both were created in f453dec without it.
Helm removes the resources it created on helm uninstall unless they carry that annotation. The Postgres data volume isn't one of those, it comes from the postgresql subchart's StatefulSet volumeClaimTemplate, so Kubernetes keeps it.
So an uninstall takes the AES encryption key away and leaves the database behind. A reinstall generates a fresh key, and everything written under the old one becomes unreadable. Names, email, DOB, mobile, address, next of kin, plus Organisation.elsaToken and Study.redcapToken. The app would start normally, so this surfaces as ciphertext appearing in the UI rather than as an error.
Ordinary deploys aren't affected. The lookup in _helpers.tpl reuses the existing Secret on helm upgrade, so the key survives a normal release. This is specifically about uninstall and reinstall, which is what happens when a deployment gets cleared down or moved between clusters.
Same shape as #701 (Redeploy loses database password), which PR #709 addressed for the postgres password by adding the annotation. The other two secrets were never brought in line.
Fix: add "helm.sh/resource-policy": keep to the metadata annotations in aeskey.yaml and jwt.yaml, matching postgres.yaml.
- 主要语言
- TypeScript
- 星标
- 4
- 派生
- 0
- 平均合并
- 14 小时 50 分钟
- 30 天内合并 PR
- 5
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
Garvan-Data-Science-Platform/ctrl 的其他 Issue
-
难度 1/5 1-3 小时 新手友好度 82/100
-
admin-client backend bug
难度 2/5 1-3 小时 新手友好度 76/100
-
backend bug
难度 2/5 1-3 小时 新手友好度 68/100
Garvan-Data-Science-Platform/ctrl#970 · 1 条评论 ·
-
backend bug
难度 2/5 1-3 小时 新手友好度 72/100
-
backend bug
难度 2/5 1-3 小时 新手友好度 78/100
查看 Garvan-Data-Science-Platform/ctrl 的全部 Issue
相似的 Issue
-
area:security documentation effort:S priority:P2
难度 2/5 1-3 小时 新手友好度 65/100
维护者通常 1 天内回复
-
app:web meta:ops
难度 2/5 半天 新手友好度 78/100
osu-tournament-rating/otr#1113 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 82/100
-
难度 2/5 1-3 小时 新手友好度 65/100
typegoose/mongodb-memory-server#1040 ·
-
bug
难度 2/5 1-3 小时 新手友好度 92/100