Role and study-admin privilege changes send no notification to the affected user
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 1-2 天
- 新手友好度
- 58/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 冷清
- 技术栈
- typescript
调研方向
Start with UsersController.updateUserRole, UsersController.makeStudyAdmin, and UsersController.removeStudyAdmin, then trace how the project currently sends notification emails. Check related issues #928 and #929 for existing notification patterns. Done means each listed role or study-admin transition sends an appropriate email to the affected user.
由索引模型根据 Issue 内容生成。
描述
Three admin-initiated endpoints let a caller change a user's role or study admin privileges but none of them notify the affected user:
PATCH /users/{userID}/role(UsersController.updateUserRole) — OperatorAdmin can change any user's role between OperatorAdmin, OrganisationAdmin, StudyAdmin, and ParticipantPOST /users/{userId}/make-study-admin/{studyId}(UsersController.makeStudyAdmin) — grants StudyAdmin over a specific studyPOST /users/{userId}/remove-study-admin/{studyId}(UsersController.removeStudyAdmin) — removes StudyAdmin from a specific study
Being promoted to OrganisationAdmin (or having admin privileges revoked) is an auth-relevant change the user should be aware of, both for their own visibility and as an audit signal in case the change was made by a compromised admin account.
Related to #928 and #929 which flag the same silent behaviour on password reset and profile edits.
Suggested fix: send a notification email on each of these transitions ("You have been made a StudyAdmin of X" / "Your CTRL admin role has been changed to Y" / "You are no longer a StudyAdmin of X. If this wasn't you, contact support.").
- 主要语言
- TypeScript
- 星标
- 4
- 派生
- 0
- 平均合并
- 14 小时 50 分钟
- 30 天内合并 PR
- 5
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
Garvan-Data-Science-Platform/ctrl 的其他 Issue
-
难度 1/5 1-3 小时 新手友好度 82/100
-
admin-client backend bug
难度 2/5 1-3 小时 新手友好度 76/100
-
backend bug
难度 2/5 1-3 小时 新手友好度 68/100
Garvan-Data-Science-Platform/ctrl#970 · 1 条评论 ·
-
backend bug
难度 2/5 1-3 小时 新手友好度 72/100
-
backend bug
难度 2/5 1-3 小时 新手友好度 78/100
查看 Garvan-Data-Science-Platform/ctrl 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
status:approved type:bug
难度 1/5 1 小时以内 新手友好度 70/100
维护者通常 1 天内回复
-
stage:4
难度 2/5 1-3 小时 新手友好度 65/100
ilan-pinto/roaring-lions#598 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
Frontmatter next to `src:` is applied to every imported slide, not only the first (undocumented)未关闭
难度 2/5 1-3 小时 新手友好度 62/100
维护者通常 1 天内回复