Two wrapped lists with items of same name conflict when XML Annotations and both JaxbAnnotationModule and JakartaXmlBindAnnotationModule are used

未关闭
#934 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
55/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
java
领域
backend

调研方向

Start by tracing how the XML module combines annotations from JaxbAnnotationModule and JakartaXmlBindAnnotationModule when discovering wrapped list properties. Reproduce the reported failure with the supplied Wrapper record and both modules, then compare it with the Jackson XML annotations case. Done means serialization succeeds for both lists with the same @XmlElement name when both annotation modules are registered.

由索引模型根据 Issue 内容生成。

描述

This seems a very specific case left after https://github.com/FasterXML/jackson-dataformat-xml/issues/192 was solved.

Using Jackson 3.3.0, this:

import java.util.List;

import javax.xml.bind.annotation.XmlElement;
import javax.xml.bind.annotation.XmlElementWrapper;

import org.junit.jupiter.api.Test;

import tools.jackson.dataformat.xml.XmlMapper;
import tools.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationModule;
import tools.jackson.module.jaxb.JaxbAnnotationModule;


class NestedListsWithObjectsWithJaxbAndJakartaModules {
 
    record Wrapper(@XmlElementWrapper(name = "ones") @XmlElement(name = "name") List<String> ones,
            @XmlElementWrapper(name = "twos") @XmlElement(name = "name") List<String> twos) {
    }
 
    @Test
    void shouldHandleNestedListsWithObjectsWithJaxbAndJakartaModules() {
        Wrapper wrapper = new Wrapper(List.of("item0"), List.of("item1"));
        XmlMapper.builder()
                .addModules(new JaxbAnnotationModule())
                .addModule(new JakartaXmlBindAnnotationModule())
                .build()
                .writeValueAsString(wrapper);
    }
}

fails with:

tools.jackson.databind.exc.InvalidDefinitionException: Invalid type definition for type `test.NestedListsWithObjectsWithJaxbAndJakartaModules$Wrapper`: Conflicting getter definitions for property "name": test.NestedListsWithObjectsWithJaxbAndJakartaModules$Wrapper#ones() vs test.NestedListsWithObjectsWithJaxbAndJakartaModules$Wrapper#twos()
at [No location information]
               at tools.jackson.databind.exc.InvalidDefinitionException.from(InvalidDefinitionException.java:75)
               at tools.jackson.databind.SerializationContext.reportBadTypeDefinition(SerializationContext.java:1366)
               at tools.jackson.databind.DatabindContext.reportBadTypeDefinition(DatabindContext.java:712)
               at tools.jackson.databind.SerializationContext._createAndCacheUntypedSerializer(SerializationContext.java:1026)
               at tools.jackson.databind.SerializationContext.findValueSerializer(SerializationContext.java:829)
               at tools.jackson.databind.SerializationContext.findTypedValueSerializer(SerializationContext.java:625)
               at tools.jackson.dataformat.xml.ser.XmlSerializationContext.serializeValue(XmlSerializationContext.java:80)
               at tools.jackson.databind.ObjectMapper._configAndWriteValue(ObjectMapper.java:1921)
               at tools.jackson.databind.ObjectMapper.writeValueAsString(ObjectMapper.java:1857)
               at test.NestedListsWithObjectsWithJaxbAndJakartaModules.shouldHandleNestedListsWithObjectsWithJaxbAndJakartaModules(NestedListsWithObjectsWithJaxbAndJakartaModules.java:28)
               Suppressed: tools.jackson.core.exc.StreamWriteException: Trying to write END_DOCUMENT when document has no root (ie. trying to output empty document).
at [No location information]
                              at tools.jackson.dataformat.xml.util.StaxUtil.throwAsWriteException(StaxUtil.java:29)
                              at tools.jackson.dataformat.xml.ser.ToXmlGenerator._closeInput(ToXmlGenerator.java:1862)
                              at tools.jackson.core.base.GeneratorBase.close(GeneratorBase.java:335)
                              at tools.jackson.databind.util.ClassUtil.closeOnFailAndThrowAsJacksonE(ClassUtil.java:413)
                              at tools.jackson.databind.ObjectMapper._configAndWriteValue(ObjectMapper.java:1923)
                              ... 2 more
               Caused by: com.ctc.wstx.exc.WstxOutputException: Trying to write END_DOCUMENT when document has no root (ie. trying to output empty document).
                              at com.ctc.wstx.sw.BaseStreamWriter.throwOutputError(BaseStreamWriter.java:1618)
                              at com.ctc.wstx.sw.BaseStreamWriter.reportNwfStructure(BaseStreamWriter.java:1653)
                              at com.ctc.wstx.sw.BaseStreamWriter._finishDocument(BaseStreamWriter.java:1457)
                              at com.ctc.wstx.sw.BaseStreamWriter.closeCompletely(BaseStreamWriter.java:962)
                              at tools.jackson.dataformat.xml.ser.ToXmlGenerator._closeInput(ToXmlGenerator.java:1857)
                              ... 5 more

This only happens if both JaxbAnnotationModule and JakartaXmlBindAnnotationModule are used. And only if @XmlElementWrapper and @XmlElement (does not matter if from the javax or jakarta package) are used. It works with @JacksonXmlElementWrapper and @JacksonXmlProperty.

By the way: Thank you very much for providing Jackson!

主要语言
Java
星标
636
派生
250
平均合并
7 小时 10 分钟
30 天内合并 PR
8

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

FasterXML/jackson-dataformat-xml 的其他 Issue

查看 FasterXML/jackson-dataformat-xml 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。