Two wrapped lists with items of same name conflict when XML Annotations and both JaxbAnnotationModule and JakartaXmlBindAnnotationModule are used

Aperta
  • Qualcosa non va?
#934 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
java
Ambito
backend

Direzione di ricerca

Start by tracing how the XML module combines annotations from JaxbAnnotationModule and JakartaXmlBindAnnotationModule when discovering wrapped list properties. Reproduce the reported failure with the supplied Wrapper record and both modules, then compare it with the Jackson XML annotations case. Done means serialization succeeds for both lists with the same @XmlElement name when both annotation modules are registered.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

This seems a very specific case left after https://github.com/FasterXML/jackson-dataformat-xml/issues/192 was solved.

Using Jackson 3.3.0, this:

import java.util.List;

import javax.xml.bind.annotation.XmlElement;
import javax.xml.bind.annotation.XmlElementWrapper;

import org.junit.jupiter.api.Test;

import tools.jackson.dataformat.xml.XmlMapper;
import tools.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationModule;
import tools.jackson.module.jaxb.JaxbAnnotationModule;


class NestedListsWithObjectsWithJaxbAndJakartaModules {
 
    record Wrapper(@XmlElementWrapper(name = "ones") @XmlElement(name = "name") List<String> ones,
            @XmlElementWrapper(name = "twos") @XmlElement(name = "name") List<String> twos) {
    }
 
    @Test
    void shouldHandleNestedListsWithObjectsWithJaxbAndJakartaModules() {
        Wrapper wrapper = new Wrapper(List.of("item0"), List.of("item1"));
        XmlMapper.builder()
                .addModules(new JaxbAnnotationModule())
                .addModule(new JakartaXmlBindAnnotationModule())
                .build()
                .writeValueAsString(wrapper);
    }
}

fails with:

tools.jackson.databind.exc.InvalidDefinitionException: Invalid type definition for type `test.NestedListsWithObjectsWithJaxbAndJakartaModules$Wrapper`: Conflicting getter definitions for property "name": test.NestedListsWithObjectsWithJaxbAndJakartaModules$Wrapper#ones() vs test.NestedListsWithObjectsWithJaxbAndJakartaModules$Wrapper#twos()
at [No location information]
               at tools.jackson.databind.exc.InvalidDefinitionException.from(InvalidDefinitionException.java:75)
               at tools.jackson.databind.SerializationContext.reportBadTypeDefinition(SerializationContext.java:1366)
               at tools.jackson.databind.DatabindContext.reportBadTypeDefinition(DatabindContext.java:712)
               at tools.jackson.databind.SerializationContext._createAndCacheUntypedSerializer(SerializationContext.java:1026)
               at tools.jackson.databind.SerializationContext.findValueSerializer(SerializationContext.java:829)
               at tools.jackson.databind.SerializationContext.findTypedValueSerializer(SerializationContext.java:625)
               at tools.jackson.dataformat.xml.ser.XmlSerializationContext.serializeValue(XmlSerializationContext.java:80)
               at tools.jackson.databind.ObjectMapper._configAndWriteValue(ObjectMapper.java:1921)
               at tools.jackson.databind.ObjectMapper.writeValueAsString(ObjectMapper.java:1857)
               at test.NestedListsWithObjectsWithJaxbAndJakartaModules.shouldHandleNestedListsWithObjectsWithJaxbAndJakartaModules(NestedListsWithObjectsWithJaxbAndJakartaModules.java:28)
               Suppressed: tools.jackson.core.exc.StreamWriteException: Trying to write END_DOCUMENT when document has no root (ie. trying to output empty document).
at [No location information]
                              at tools.jackson.dataformat.xml.util.StaxUtil.throwAsWriteException(StaxUtil.java:29)
                              at tools.jackson.dataformat.xml.ser.ToXmlGenerator._closeInput(ToXmlGenerator.java:1862)
                              at tools.jackson.core.base.GeneratorBase.close(GeneratorBase.java:335)
                              at tools.jackson.databind.util.ClassUtil.closeOnFailAndThrowAsJacksonE(ClassUtil.java:413)
                              at tools.jackson.databind.ObjectMapper._configAndWriteValue(ObjectMapper.java:1923)
                              ... 2 more
               Caused by: com.ctc.wstx.exc.WstxOutputException: Trying to write END_DOCUMENT when document has no root (ie. trying to output empty document).
                              at com.ctc.wstx.sw.BaseStreamWriter.throwOutputError(BaseStreamWriter.java:1618)
                              at com.ctc.wstx.sw.BaseStreamWriter.reportNwfStructure(BaseStreamWriter.java:1653)
                              at com.ctc.wstx.sw.BaseStreamWriter._finishDocument(BaseStreamWriter.java:1457)
                              at com.ctc.wstx.sw.BaseStreamWriter.closeCompletely(BaseStreamWriter.java:962)
                              at tools.jackson.dataformat.xml.ser.ToXmlGenerator._closeInput(ToXmlGenerator.java:1857)
                              ... 5 more

This only happens if both JaxbAnnotationModule and JakartaXmlBindAnnotationModule are used. And only if @XmlElementWrapper and @XmlElement (does not matter if from the javax or jakarta package) are used. It works with @JacksonXmlElementWrapper and @JacksonXmlProperty.

By the way: Thank you very much for providing Jackson!

Lingua principale
Java
Stelle
636
Fork
250
Merge medio
7h 10m
PR unite (30g)
8

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di FasterXML/jackson-dataformat-xml

Tutte le issue di FasterXML/jackson-dataformat-xml

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.