Workflows: publish and merge-gate leave a write-scoped token in .git/config while npm install scripts run

未关闭
#281 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@FredApps 已经在做这个了。

开始于 2026年11月17日。

  • #282 来自 @FredApps —— 未关闭

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
github-actions, typescript
领域
ci-cd, security

调研方向

Read .github/workflows/release-cli.yml and .github/workflows/ci.yml, focusing on the publish and merge-gate checkouts and the later npm ci steps. Set persist-credentials: false for both checkouts, then verify neither job relies on the stored credential for a Git operation; pull request #282 is already open against this issue.

由索引模型根据 Issue 内容生成。

描述

Two jobs check out the repository with the default persist-credentials: true while their GITHUB_TOKEN has a write scope, then run npm ci with install scripts enabled:

Workflow Job Token scopes Later step that runs third-party code
release-cli.yml publish contents: write, id-token: write npm ci --no-audit --fund=false in packages/diffci-cli (scripts on)
ci.yml merge-gate checks: write npm ci --no-audit --fund=false in packages/diffci-cli (scripts on)

actions/checkout writes the job token into .git/config as an http.https://github.com/.extraheader entry, where every later step in the job can read it, including a dependency's preinstall/postinstall script. In publish that token can push to main, move tags and edit releases.

Neither job needs the stored credential:

  • publish creates the GitHub Release, the action-v tag and the release assets through gh/the API with GH_TOKEN, and GIT_SSH_COMMAND is already /bin/false. Its only git commands read history (rev-parse), and its checkout has fetch-depth: 0, so the Action smoke never fetches.
  • merge-gate posts its check run with the Action's github-token input. The Action's --unshallow fetch of a public repository works without credentials.

scorecard.yml, codeql.yml and rust-replay.yml already set persist-credentials: false. credit-contributors.yml needs the stored token because it runs git push.

Reproduce

grep -n -A3 'actions/checkout' .github/workflows/release-cli.yml: the publish job's checkout sets only fetch-depth: 0, and the job has contents: write. The same is true for merge-gate in ci.yml, with checks: write.

Expected: a job whose token can write, and that does not git push, checks out with persist-credentials: false.

主要语言
TypeScript
星标
0
派生
4
平均合并
18 小时 41 分钟
30 天内合并 PR
48

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

DiffCI/core 的其他 Issue

查看 DiffCI/core 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。