Workflows: publish and merge-gate leave a write-scoped token in .git/config while npm install scripts run

Aperta
#281 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@FredApps ci sta già lavorando.

Dal 17/11/2026.

  • #282 di @FredApps — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
github-actions, typescript
Ambito
ci-cd, security

Direzione di ricerca

Read .github/workflows/release-cli.yml and .github/workflows/ci.yml, focusing on the publish and merge-gate checkouts and the later npm ci steps. Set persist-credentials: false for both checkouts, then verify neither job relies on the stored credential for a Git operation; pull request #282 is already open against this issue.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Two jobs check out the repository with the default persist-credentials: true while their GITHUB_TOKEN has a write scope, then run npm ci with install scripts enabled:

Workflow Job Token scopes Later step that runs third-party code
release-cli.yml publish contents: write, id-token: write npm ci --no-audit --fund=false in packages/diffci-cli (scripts on)
ci.yml merge-gate checks: write npm ci --no-audit --fund=false in packages/diffci-cli (scripts on)

actions/checkout writes the job token into .git/config as an http.https://github.com/.extraheader entry, where every later step in the job can read it, including a dependency's preinstall/postinstall script. In publish that token can push to main, move tags and edit releases.

Neither job needs the stored credential:

  • publish creates the GitHub Release, the action-v tag and the release assets through gh/the API with GH_TOKEN, and GIT_SSH_COMMAND is already /bin/false. Its only git commands read history (rev-parse), and its checkout has fetch-depth: 0, so the Action smoke never fetches.
  • merge-gate posts its check run with the Action's github-token input. The Action's --unshallow fetch of a public repository works without credentials.

scorecard.yml, codeql.yml and rust-replay.yml already set persist-credentials: false. credit-contributors.yml needs the stored token because it runs git push.

Reproduce

grep -n -A3 'actions/checkout' .github/workflows/release-cli.yml: the publish job's checkout sets only fetch-depth: 0, and the job has contents: write. The same is true for merge-gate in ci.yml, with checks: write.

Expected: a job whose token can write, and that does not git push, checks out with persist-credentials: false.

Lingua principale
TypeScript
Stelle
0
Fork
4
Merge medio
18h 41m
PR unite (30g)
48

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di DiffCI/core

Tutte le issue di DiffCI/core

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.