Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

brokered_connections: two reads carry no provider predicate (blocks the provider sunset flow)

未关闭
  • 哪里不对？
#783 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript
领域
authorization, backend

调研方向

Start in server/src/plugins/store.ts at retireConnectionsFor and brokeredConnectionsFor, which lack the provider predicate the other selects use, and check the comments there that point to assertActivatable in server/src/index.ts. Done means both reads filter on the active broker provider and a test covering the offboarding sweep with a foreign-provider row shows it is neither revoked through the active broker nor audited as revoked. The fix is gated on the provider sunset flow, so confirm with maintainers before starting.

由索引模型根据 Issue 内容生成。

描述

Two brokered_connections reads in server/src/plugins/store.ts carry no provider predicate, where the other 11 selects in that file all filter on the active broker:

  • retireConnectionsFor — the offboarding sweep
  • brokeredConnectionsFor — the settings-page read

Both are keyed (holder = 'person', userId) only.

Why it matters

retireConnectionsFor finds a person's connections and then calls the active broker's revoke() for each row it found. On a deployment holding rows from both providers, that is a revocation requested at the wrong vendor — which would not recognise the connection — while the audit row records vendorRevocationRequested about access that was never removed. A departed employee keeps live access and the record says otherwise.

brokeredConnectionsFor is milder: rows are resolved at the active provider's canonical URL, so another provider's connections are silently dropped from the settings page.

Why it is not urgent

Unreachable today. The startup activation refusal (assertActivatable, called from server/src/index.ts) refuses to boot when the configured provider differs from the provider on the existing rows, so a mixed deployment cannot start and neither read can see a foreign row.

Both sites were already unfiltered before the Arcade provider work began (base 7b1c20a) — this is pre-existing, not a regression.

Why it needs an issue rather than a fix now

The provider sunset flow is exactly the change that relaxes assertActivatable's refusal, and it turns both sites live. Whoever builds it must add the brokerProvider predicate to both reads. Both call sites now carry comments saying so and naming assertActivatable, but a comment is not a work item.

Also to correct

The design spec's inventory of provider-filtered sites lists the offboarding sweep among them. It is not one — the sweep has no provider filter at all. That line should be corrected when the sunset flow is specced.

Acceptance
  • Both reads filter on the active broker provider.
  • A test drives the offboarding sweep on a deployment holding a foreign-provider row and asserts it is not revoked through the active broker and not audited as revoked.

Context: filed from the Arcade provider PR (#770), which does not change either read.

主要语言
TypeScript
星标
6.6k
派生
914
平均合并
17 小时 52 分钟
30 天内合并 PR
155

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

CopilotKit/OpenBot 的其他 Issue

查看 CopilotKit/OpenBot 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。