Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

brokered_connections: two reads carry no provider predicate (blocks the provider sunset flow)

Abierto
  • ¿Algo no está bien?
#783 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript
Área
authorization, backend

Línea de trabajo

Start in server/src/plugins/store.ts at retireConnectionsFor and brokeredConnectionsFor, which lack the provider predicate the other selects use, and check the comments there that point to assertActivatable in server/src/index.ts. Done means both reads filter on the active broker provider and a test covering the offboarding sweep with a foreign-provider row shows it is neither revoked through the active broker nor audited as revoked. The fix is gated on the provider sunset flow, so confirm with maintainers before starting.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Two brokered_connections reads in server/src/plugins/store.ts carry no provider predicate, where the other 11 selects in that file all filter on the active broker:

  • retireConnectionsFor — the offboarding sweep
  • brokeredConnectionsFor — the settings-page read

Both are keyed (holder = 'person', userId) only.

Why it matters

retireConnectionsFor finds a person's connections and then calls the active broker's revoke() for each row it found. On a deployment holding rows from both providers, that is a revocation requested at the wrong vendor — which would not recognise the connection — while the audit row records vendorRevocationRequested about access that was never removed. A departed employee keeps live access and the record says otherwise.

brokeredConnectionsFor is milder: rows are resolved at the active provider's canonical URL, so another provider's connections are silently dropped from the settings page.

Why it is not urgent

Unreachable today. The startup activation refusal (assertActivatable, called from server/src/index.ts) refuses to boot when the configured provider differs from the provider on the existing rows, so a mixed deployment cannot start and neither read can see a foreign row.

Both sites were already unfiltered before the Arcade provider work began (base 7b1c20a) — this is pre-existing, not a regression.

Why it needs an issue rather than a fix now

The provider sunset flow is exactly the change that relaxes assertActivatable's refusal, and it turns both sites live. Whoever builds it must add the brokerProvider predicate to both reads. Both call sites now carry comments saying so and naming assertActivatable, but a comment is not a work item.

Also to correct

The design spec's inventory of provider-filtered sites lists the offboarding sweep among them. It is not one — the sweep has no provider filter at all. That line should be corrected when the sunset flow is specced.

Acceptance
  • Both reads filter on the active broker provider.
  • A test drives the offboarding sweep on a deployment holding a foreign-provider row and asserts it is not revoked through the active broker and not audited as revoked.

Context: filed from the Arcade provider PR (#770), which does not change either read.

Lenguaje dominante
TypeScript
Estrellas
6.6k
Forks
914
Merge medio
19 h 22 min
PR fusionados (30 d)
140

Preparar el entorno

  • Incluye un Dockerfile o un archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de CopilotKit/OpenBot

Todos los issues de CopilotKit/OpenBot

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.