api: the OpenAPI document allows null on_value and off_value for a flag, which the API refuses
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start with the FeatureFlagCreate and FeatureFlagUpdate schemas in docs/api/openapi-v1.full.json and docs/api/openapi-v1.stable.json, where on_value and off_value lack a type. Check the API's Python validation that returns null_not_allowed, and follow the #954 stability row as the format for any new entry. Done means both properties exclude null in the served document, a test pins that, and both snapshots are regenerated. The fix needs serial merge ordering and a fuzz run before merge, so confirm with maintainers first.
由索引模型根据 Issue 内容生成。
描述
The served OpenAPI document leaves on_value and off_value on FeatureFlagCreate and FeatureFlagUpdate without a type, so it allows any JSON value, null included. The API refuses null for them: in a measured run, 135 of 150 flag creates that the document allows answered 422 with null_not_allowed.
Both snapshots (docs/api/openapi-v1.full.json and docs/api/openapi-v1.stable.json) carry the untyped properties since #1514, which is not yet in a release. The next release would publish them in the stable document; fixing them after that needs a stability row (the #954 row is the shape), with no behaviour change.
Expected
The document describes exactly what the API accepts for on_value and off_value, and a test pins it.
Notes
The fix changes the request side of the served document, so it is its own pull request, regenerates both snapshots (merged serially with the other snapshot pull requests) and dispatches the API fuzz run before merge.
Priority
LOW.
- 主要语言
- Python
- 星标
- 0
- 派生
- 4
- 平均合并
- 5 小时 19 分钟
- 30 天内合并 PR
- 503
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
Controlvar/controlvar 的其他 Issue
-
bug post-launch
难度 2/5 1-3 小时 新手友好度 68/100
Controlvar/controlvar#1737 ·
维护者通常 1 天内回复
-
fix(api): the feature-flag list has no defined order across pages可能已有人在做 @amarkanday 今天认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 72/100
Controlvar/controlvar#1612 ·
维护者通常 1 天内回复
-
bug post-launch
难度 2/5 1-3 小时 新手友好度 70/100
Controlvar/controlvar#1562 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 90/100
Controlvar/controlvar#1447 · 2 条评论 ·
维护者通常 1 天内回复
-
bug post-launch
难度 2/5 1-3 小时 新手友好度 72/100
Controlvar/controlvar#1428 ·
维护者通常 1 天内回复
查看 Controlvar/controlvar 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 69/100
jejjohnson/gaussx#752 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 85/100
521xueweihan/HelloGitHub#4270 ·
-
enhancement owner: den-haag
难度 2/5 1-3 小时 新手友好度 67/100
维护者通常 6 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
ok-oldking/ok-wuthering-waves#1828 ·
维护者通常 1 天内回复
-
lesson-submission pending-review
难度 1/5 1 小时以内 新手友好度 65/100
Ikalus1988/MisakaNet#4512 ·
维护者通常 1 天内回复