time_window does not read ISO datetimes in start and end

未关闭
  • 哪里不对？
#1,156 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
65/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
python
领域
backend

调研方向

Start by locating the rules-engine parsing for time_window and the flag/experiment save validation path, then compare how start/end, start_time/end_time, and date fields are read. Add or update tests around ISO datetime windows, including the now-1h to now+1h case. Done means either start/end interpret ISO datetimes as an absolute window, or saving rejects unsupported values with a message listing accepted forms.

由索引模型根据 Issue 内容生成。

描述

enhancement post-launch

A time_window condition whose start/end are ISO datetimes is not read by the rules engine. Measured on 0.28.2 with flag targeting: a window from now-1h to now+1h does not match. Experiment targeting matches it today, but #1145 makes experiments use the same implementation as flags, so after #1145 neither matches.

The engine reads HH:MM times (start/end in the dashboard shape, start_time/end_time natively), days, and start_date/end_date.

Expected: one of these:

  • start/end accept ISO datetimes and mean an absolute window;
  • or the API refuses a time_window value it cannot read when the flag or experiment is saved, with a message naming the accepted forms.

Not needed for launch: after #1145 such a window matches nobody, which is the safe direction; this issue makes it usable.

🤖 Generated with Claude Code

主要语言
Python
星标
0
派生
4
平均合并
5 小时 36 分钟
30 天内合并 PR
509

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

Controlvar/controlvar 的其他 Issue

查看 Controlvar/controlvar 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。