The API starts without logging, metrics or request IDs if their imports fail, and records no reason

未关闭
  • 哪里不对？
#1,041 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
68/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
prometheus, python
领域
backend, observability, testing

调研方向

Start with backend/app/main.py around lines 30-48, where the monitoring imports and exception handling are defined, and inspect the /health/ready endpoint. First determine which logging, metrics, and request-ID components are required outside development and test, then preserve the failed exception for optional components and expose degraded readiness. Add a test that makes each import fail and verifies whether startup stops or readiness reports degraded.

由索引模型根据 Issue 内容生成。

描述

bug post-launch

backend/app/main.py (lines ~30-48) imports the logging setup, the Prometheus middleware and the request-ID middleware inside try: ... except Exception: _monitoring_imports_ok = False (marked # pragma: no cover). If any of those imports fails, the API starts without structured logging, metrics or request IDs, and nothing records why: the exception is discarded.

Expected: decide which of these are optional. A failure to import a required one stops startup outside development/test (as a broken module install already does); an optional one logs the exception and shows up in /health/ready as degraded. A test imports main with one of them made to fail and checks the result. Found in a code review (2026-10-06).

主要语言
Python
星标
0
派生
4
平均合并
5 小时 36 分钟
30 天内合并 PR
509

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

Controlvar/controlvar 的其他 Issue

查看 Controlvar/controlvar 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。