Positioning new windows based on the BOB display's x and y properties
维护者通常 2 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start with the cited DockItemRepresentation.java code and trace how command-line launches with target=window are handled. Compare that path with the ActionButton behavior for position and dimensions. The issue asks whether to change the default or add an opt-in preference, so the intended behavior needs agreement before implementation can be considered done.
由索引模型根据 Issue 内容生成。
描述
When a display is launched from the command line and opened as a 'New Window', i.e. phoebus -resource file:/xx/xxx/file.bob?target=window, it will always be positioned at the default x=50, y=50 location on the monitor.
However, when you open a display from an ActionButton in the 'New Window' mode, it reads the x and y defined in the BOB file and positions that display in that location:
https://github.com/ControlSystemStudio/phoebus/blob/31059edc069e5d1df75202c1d6f31972e0a5b868/app/display/runtime/src/main/java/org/csstudio/display/builder/runtime/app/DockItemRepresentation.java#L65
The same is also true of width & height. Opening from an ActionButton will open the window with dimensions based on the BOB display's width and height properties:
https://github.com/ControlSystemStudio/phoebus/blob/31059edc069e5d1df75202c1d6f31972e0a5b868/app/display/runtime/src/main/java/org/csstudio/display/builder/runtime/app/DockItemRepresentation.java#L86
, while launching from a terminal using the default 1600 x 900 dimensions.
These two behaviors seem inconsistent. While I know that you can manually specify the width, height, x and y from the command line, I was wondering whether the default behavior when launching a new window from the terminal should be to position the new window at the x and y defined in the model and resize the window accordingly?
This was also what used to be done by CS-Studio when you opened with Position=NEW_SHELL in the command line argument.
Any thoughts on whether this would be a reasonable thing to do? It would impact the existing behavior so we may need to use an 'opt in' preference.
- 主要语言
- Java
- 星标
- 130
- 派生
- 132
- 平均合并
- 2 天 11 小时
- 30 天内合并 PR
- 19
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
ControlSystemStudio/phoebus 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 62/100
ControlSystemStudio/phoebus#3983 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
ControlSystemStudio/phoebus#3979 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 80/100
ControlSystemStudio/phoebus#3962 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
ControlSystemStudio/phoebus#3865 · 1 条评论 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 52/100
ControlSystemStudio/phoebus#3980 ·
维护者通常 2 天内回复
查看 ControlSystemStudio/phoebus 的全部 Issue
相似的 Issue
-
[Bug]: REST API URL starting with "http" but no scheme (e.g. httpbin.org/get) is not given an http:// prefix可能已有人在做 @ItsDeadlyProgrammer 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 68/100
appsmithorg/appsmith#42471 · 1 条评论 ·
维护者通常 2 天内回复
-
code-maintenance
难度 2/5 1-3 小时 新手友好度 77/100
维护者通常 1 天内回复
-
bug priority: medium Review effort [1-5]: 3 status: needs-triage type: bug
难度 2/5 1-3 小时 新手友好度 82/100
carlos-emr/carlos#5258 ·
维护者通常 1 天内回复
-
bug: author create/update with an unknown avatarId returns 404 instead of 400 UNKNOWN_REFERENCE可能已有人在做 @Vinu2111 今天认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 74/100
atomityhq/blog-cms#59 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复