Someone at a city's gate is asked to accept new rules if they use a house link
已经有一个关联 PR 被合并了。
- #87 来自 @CakeRepository —— 已合并
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 72/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- javascript, rust
- 领域
- backend
调研方向
Start at src/city.rs:561, then compare the city-gate and house-link paths for the POST /api/house-invites/{code}/join endpoint. Trace the accept_rules handling in web/app.js:786 and check the behavior described in docs/accounts-and-trust.md:194 and docs/city.md:387. Done means an already-waiting person is not asked to accept new rules when joining through a house link, with the implementation and documentation agreeing.
由索引模型根据 Issue 内容生成。
描述
What happened
T14 says "someone already at the gate when they change isn't asked again" (docs/accounts-and-trust.md:194). On the city's link that holds. On a house link it doesn't: src/city.rs:561 only asks whether they're in the city, not whether they were already waiting.
docs/city.md:387 agrees with the code, so the two docs disagree. The page sends accept_rules for you (web/app.js:786), so this shows through the API.
I expected the same answer from either link.
Where
POST /api/house-invites/{code}/join
How to see it again
- Someone is waiting at a city's gate.
- The keeper adds
rules_text. - A resident gives them a house link, and they post
{}to the join route.
It's refused until they send accept_rules.
Found by reading the code at commit 2369ff5. Cargo wasn't available, so this hasn't been run.
- 主要语言
- Rust
- 星标
- 2
- 派生
- 0
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
CakeRepository/agentshangout 的其他 Issue
-
CakeRepository/agentshangout#915 ·
-
CakeRepository/agentshangout#913 · 1 条评论 ·
-
CakeRepository/agentshangout#878 ·
-
难度 4/5 3-5 天 新手友好度 48/100
CakeRepository/agentshangout#814 ·
-
难度 5/5 一周以上 新手友好度 35/100
CakeRepository/agentshangout#770 ·
查看 CakeRepository/agentshangout 的全部 Issue
相似的 Issue
-
needs-triage tooling
难度 1/5 1 小时以内 新手友好度 90/100
neilsh/stunt-reel#317 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 84/100
storytold/craft-fonts#65 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 86/100
storytold/craft-libs#723 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 84/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 83/100
n0-computer/iroh#4669 · 1 条评论 ·
维护者通常 1 天内回复