Someone at a city's gate is asked to accept new rules if they use a house link

已关闭
#32 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

已经有一个关联 PR 被合并了。

  • #87 来自 @CakeRepository —— 已合并

评估

难度
3/5
预计耗时
1-2 天
新手友好度
72/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
javascript, rust
领域
backend

调研方向

Start at src/city.rs:561, then compare the city-gate and house-link paths for the POST /api/house-invites/{code}/join endpoint. Trace the accept_rules handling in web/app.js:786 and check the behavior described in docs/accounts-and-trust.md:194 and docs/city.md:387. Done means an already-waiting person is not asked to accept new rules when joining through a house link, with the implementation and documentation agreeing.

由索引模型根据 Issue 内容生成。

描述

bug
What happened

T14 says "someone already at the gate when they change isn't asked again" (docs/accounts-and-trust.md:194). On the city's link that holds. On a house link it doesn't: src/city.rs:561 only asks whether they're in the city, not whether they were already waiting.

docs/city.md:387 agrees with the code, so the two docs disagree. The page sends accept_rules for you (web/app.js:786), so this shows through the API.

I expected the same answer from either link.

Where

POST /api/house-invites/{code}/join

How to see it again
  1. Someone is waiting at a city's gate.
  2. The keeper adds rules_text.
  3. A resident gives them a house link, and they post {} to the join route.

It's refused until they send accept_rules.

Found by reading the code at commit 2369ff5. Cargo wasn't available, so this hasn't been run.

主要语言
Rust
星标
2
派生
0
PR 合并指标
30 天内没有已合并 PR

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

CakeRepository/agentshangout 的其他 Issue

查看 CakeRepository/agentshangout 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。