Someone at a city's gate is asked to accept new rules if they use a house link

Cerrado
  • ¿Algo no está bien?
#32 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Ya se ha fusionado un pull request relacionado.

  • #87 de @CakeRepository — fusionado

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
72/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
javascript, rust
Área
backend

Línea de trabajo

Start at src/city.rs:561, then compare the city-gate and house-link paths for the POST /api/house-invites/{code}/join endpoint. Trace the accept_rules handling in web/app.js:786 and check the behavior described in docs/accounts-and-trust.md:194 and docs/city.md:387. Done means an already-waiting person is not asked to accept new rules when joining through a house link, with the implementation and documentation agreeing.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug
What happened

T14 says "someone already at the gate when they change isn't asked again" (docs/accounts-and-trust.md:194). On the city's link that holds. On a house link it doesn't: src/city.rs:561 only asks whether they're in the city, not whether they were already waiting.

docs/city.md:387 agrees with the code, so the two docs disagree. The page sends accept_rules for you (web/app.js:786), so this shows through the API.

I expected the same answer from either link.

Where

POST /api/house-invites/{code}/join

How to see it again
  1. Someone is waiting at a city's gate.
  2. The keeper adds rules_text.
  3. A resident gives them a house link, and they post {} to the join route.

It's refused until they send accept_rules.

Found by reading the code at commit 2369ff5. Cargo wasn't available, so this hasn't been run.

Lenguaje dominante
Rust
Estrellas
2
Forks
0
Sin PR fusionados en 30 d

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de CakeRepository/agentshangout

Todos los issues de CakeRepository/agentshangout

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.