The documented `log_base` range accepts 1.0, but the resolver silently replaces it with 2.6
维护者通常 1 天内回复
评估
调研方向
Read astrbot/core/config/default.py at the log_base hint and _resolve_log_base in astrbot/core/pipeline/respond/stage.py to compare the advertised range with the accepted values. Check for existing tests of _resolve_log_base and its use by _calc_comp_interval. Done means the documented range and resolver behavior agree, with a test covering the boundary value.
由索引模型根据 Issue 内容生成。
描述
The documented log_base range accepts 1.0, but the resolver silently replaces it with 2.6
- Repository:
AstrBotDevs/AstrBot - Target commit:
14835b5011bbc3ffb0a76829df3e272ddeacfafa - File:
astrbot/core/config/default.py:4551-4557,astrbot/core/pipeline/respond/stage.py:17-36
Summary
The UI metadata for platform_settings.segmented_reply.log_base documents the range as
1.0-10.0, so 1.0 is presented to users as a legal value. The pipeline resolver rejects
any base <= 1 and silently substitutes DEFAULT_LOG_BASE = 2.6, so a configured 1.0
never reaches the computation and the reply interval is calculated with a different base
than the user set.
Actual behavior
With interval_method = "log" and log_base = 1.0 (the lowest value the hint allows), the
real resolver logs Unusable segmented-reply log base: 1.0, using the default 2.6 instead.
and RespondStage._calc_comp_interval calls math.log(wc + 1, 2.6); the configured value
is discarded without any indication in the UI.
Observed on the target commit:
documented_hint="对数间隔的底数,默认为 2.6。取值范围为 1.0-10.0。"
configured_log_base=1.0
resolved_log_base=2.6
math_log_base=2.6
1.0 is inside the advertised range but outside the range the code accepts, so the
documented contract and the implementation disagree. A base of exactly 1 cannot be used
by math.log (it raises ZeroDivisionError), but the metadata should not advertise it as
valid, and the resolver currently substitutes a different value rather than rejecting the
input.
Expected: a value the UI documents as legal is either honoured or rejected with a
visible error; the documented range matches the resolver's accepted range.
Reproduction
- Set
platform_settings.segmented_reply.interval_methodtologand
platform_settings.segmented_reply.log_baseto1.0(a value the configuration hint
explicitly lists as in range). - Run the responder with segmented replies enabled and send a message that triggers
segmentation. - The error log shows
Unusable segmented-reply log base: 1.0, using the default 2.6 instead., and the computed interval is derived frommath.log(n, 2.6).
A unit test can call the shipped _resolve_log_base(1.0) directly and assert whether the
result should be 1.0 (honoured), an error (rejected), or 2.6 (documented substitution) —
today it returns 2.6 while the hint says 1.0 is valid.
Relevant code
# astrbot/core/config/default.py:4551-4557
"platform_settings.segmented_reply.log_base": {
"description": "对数底数",
"type": "float",
"hint": "对数间隔的底数,默认为 2.6。取值范围为 1.0-10.0。",
"condition": {
"platform_settings.segmented_reply.interval_method": "log",
},
},
# astrbot/core/pipeline/respond/stage.py:17-36
DEFAULT_LOG_BASE = 2.6
def _resolve_log_base(value: float | str | None) -> float:
"""Return a log base that math.log accepts, or the documented default."""
try:
log_base = float(value)
except (TypeError, ValueError) as e:
logger.error(f"Failed to parse the segmented-reply log base: {e}")
return DEFAULT_LOG_BASE
if not math.isfinite(log_base) or log_base <= 1:
# math.log(words, 1) raises ZeroDivisionError and a non-positive base
# raises ValueError; both escape from _calc_comp_interval before the
# first send, so the whole reply is dropped.
logger.error(
f"Unusable segmented-reply log base: {log_base}, "
f"using the default {DEFAULT_LOG_BASE} instead.",
)
return DEFAULT_LOG_BASE
return log_base
# astrbot/core/pipeline/respond/stage.py:96-97,124
self.log_base = _resolve_log_base(
ctx.astrbot_config["platform_settings"]["segmented_reply"]["log_base"],
)
...
i = math.log(wc + 1, self.log_base)
Root cause
The metadata hint in default.py was written as an inclusive 1.0-10.0 range, while the
resolver in stage.py treats log_base <= 1 as unusable and replaces it with 2.6
(adding only an error log). The two ranges are maintained in different files with no shared
constant or test, so the UI advertises a boundary value the consumer refuses; a user who
sets the documented minimum gets a different base than requested, and the substitution is
only visible in the log.
Suggested fix
- Make the documented range match the implementation: state
(1.0, 10.0](or
1.0 < log_base <= 10.0) in the hint, or accept1.0by defining the effective base
as1.0 + epsilonand documenting that behaviour. - Derive the hint from a single shared constant (e.g.
MIN_LOG_BASE/MAX_LOG_BASE) used
by bothdefault.pyand_resolve_log_base. - Add a test asserting that every value inside the advertised range is either honoured or
produces a user-visible validation error, and that out-of-range values are rejected.
- 主要语言
- Python
- 星标
- 46.4k
- 派生
- 3.4k
- 平均合并
- 1 天 11 小时
- 30 天内合并 PR
- 120
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
AstrBotDevs/AstrBot 的其他 Issue
-
enhancement
难度 2/5 1-3 小时 新手友好度 75/100
AstrBotDevs/AstrBot#11038 · 2 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 74/100
AstrBotDevs/AstrBot#11034 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 74/100
AstrBotDevs/AstrBot#10999 · 1 条评论 ·
维护者通常 1 天内回复
-
[Bug] OpenAI-compatible Gemini 工具 schema const 导致 400可能已有人在做 @arccat-114 于 17 天前认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 77/100
AstrBotDevs/AstrBot#10720 · 1 条评论 ·
维护者通常 1 天内回复
-
[Bug] Discord slash command sync aborts with KeyError when a plugin handler is defined in a submodule可能已有人在做 @yuexia5 于 22 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 77/100
AstrBotDevs/AstrBot#10626 · 1 条评论 ·
维护者通常 1 天内回复
查看 AstrBotDevs/AstrBot 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
bytedance/agentkit-samples#277 ·
-
ai-driven-fuzzing bug claude Minor
难度 2/5 1-3 小时 新手友好度 83/100
维护者通常 2 天内回复
-
channels:edit check:passed
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
aws-samples/sample-aws-genai-db-modernizer#2097 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复