The documented `log_base` range accepts 1.0, but the resolver silently replaces it with 2.6

Đang mở
  • Có gì không ổn?
#11,060 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

@lhjl-j đang làm issue này rồi.

Từ ngày 9/11/2026.

  • #11064 của @lhjl-j — đang mở

Đánh giá

Độ khó
3/5
Thời gian dự kiến
1-2 ngày
Mức phù hợp với người mới
76/100
Loại issue
Lỗi
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
python
Lĩnh vực
backend

Hướng nghiên cứu

Read astrbot/core/config/default.py at the log_base hint and _resolve_log_base in astrbot/core/pipeline/respond/stage.py to compare the advertised range with the accepted values. Check for existing tests of _resolve_log_base and its use by _calc_comp_interval. Done means the documented range and resolver behavior agree, with a test covering the boundary value.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

The documented log_base range accepts 1.0, but the resolver silently replaces it with 2.6

  • Repository: AstrBotDevs/AstrBot
  • Target commit: 14835b5011bbc3ffb0a76829df3e272ddeacfafa
  • File: astrbot/core/config/default.py:4551-4557, astrbot/core/pipeline/respond/stage.py:17-36

Summary

The UI metadata for platform_settings.segmented_reply.log_base documents the range as
1.0-10.0, so 1.0 is presented to users as a legal value. The pipeline resolver rejects
any base <= 1 and silently substitutes DEFAULT_LOG_BASE = 2.6, so a configured 1.0
never reaches the computation and the reply interval is calculated with a different base
than the user set.

Actual behavior

With interval_method = "log" and log_base = 1.0 (the lowest value the hint allows), the
real resolver logs Unusable segmented-reply log base: 1.0, using the default 2.6 instead.
and RespondStage._calc_comp_interval calls math.log(wc + 1, 2.6); the configured value
is discarded without any indication in the UI.

Observed on the target commit:

documented_hint="对数间隔的底数，默认为 2.6。取值范围为 1.0-10.0。"
configured_log_base=1.0
resolved_log_base=2.6
math_log_base=2.6

1.0 is inside the advertised range but outside the range the code accepts, so the
documented contract and the implementation disagree. A base of exactly 1 cannot be used
by math.log (it raises ZeroDivisionError), but the metadata should not advertise it as
valid, and the resolver currently substitutes a different value rather than rejecting the
input.

Expected: a value the UI documents as legal is either honoured or rejected with a
visible error; the documented range matches the resolver's accepted range.

Reproduction
  1. Set platform_settings.segmented_reply.interval_method to log and
    platform_settings.segmented_reply.log_base to 1.0 (a value the configuration hint
    explicitly lists as in range).
  2. Run the responder with segmented replies enabled and send a message that triggers
    segmentation.
  3. The error log shows Unusable segmented-reply log base: 1.0, using the default 2.6 instead., and the computed interval is derived from math.log(n, 2.6).

A unit test can call the shipped _resolve_log_base(1.0) directly and assert whether the
result should be 1.0 (honoured), an error (rejected), or 2.6 (documented substitution) —
today it returns 2.6 while the hint says 1.0 is valid.

Relevant code
# astrbot/core/config/default.py:4551-4557
"platform_settings.segmented_reply.log_base": {
    "description": "对数底数",
    "type": "float",
    "hint": "对数间隔的底数，默认为 2.6。取值范围为 1.0-10.0。",
    "condition": {
        "platform_settings.segmented_reply.interval_method": "log",
    },
},

# astrbot/core/pipeline/respond/stage.py:17-36
DEFAULT_LOG_BASE = 2.6


def _resolve_log_base(value: float | str | None) -> float:
    """Return a log base that math.log accepts, or the documented default."""
    try:
        log_base = float(value)
    except (TypeError, ValueError) as e:
        logger.error(f"Failed to parse the segmented-reply log base: {e}")
        return DEFAULT_LOG_BASE
    if not math.isfinite(log_base) or log_base <= 1:
        # math.log(words, 1) raises ZeroDivisionError and a non-positive base
        # raises ValueError; both escape from _calc_comp_interval before the
        # first send, so the whole reply is dropped.
        logger.error(
            f"Unusable segmented-reply log base: {log_base}, "
            f"using the default {DEFAULT_LOG_BASE} instead.",
        )
        return DEFAULT_LOG_BASE
    return log_base

# astrbot/core/pipeline/respond/stage.py:96-97,124
self.log_base = _resolve_log_base(
    ctx.astrbot_config["platform_settings"]["segmented_reply"]["log_base"],
)
...
i = math.log(wc + 1, self.log_base)

Root cause

The metadata hint in default.py was written as an inclusive 1.0-10.0 range, while the
resolver in stage.py treats log_base <= 1 as unusable and replaces it with 2.6
(adding only an error log). The two ranges are maintained in different files with no shared
constant or test, so the UI advertises a boundary value the consumer refuses; a user who
sets the documented minimum gets a different base than requested, and the substitution is
only visible in the log.

Suggested fix

  1. Make the documented range match the implementation: state (1.0, 10.0] (or
    1.0 < log_base <= 10.0) in the hint, or accept 1.0 by defining the effective base
    as 1.0 + epsilon and documenting that behaviour.
  2. Derive the hint from a single shared constant (e.g. MIN_LOG_BASE/MAX_LOG_BASE) used
    by both default.py and _resolve_log_base.
  3. Add a test asserting that every value inside the advertised range is either honoured or
    produces a user-visible validation error, and that out-of-range values are rejected.
Ngôn ngữ chính
Python
Star
46.4k
Fork
3.4k
Merge trung bình
1 ngày 11 giờ
Pull request đã merge (30 ngày)
120

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của AstrBotDevs/AstrBot

Tất cả issue của AstrBotDevs/AstrBot

Issue tương tự

Thêm issue về Python

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.