ArduPilot/ardupilot

Remove mavlink enum dependencies on non related library

Open

#23,320 创建于 2023年3月24日

在 GitHub 查看
 (14 评论) (0 反应) (1 负责人)C++ (9,336 star) (15,603 fork)batch import
Enhancementgood first issue

描述

Feature request

Is your feature request related to a problem? Please describe. In numerous place, we were using mavlink enum. Those are well defined and conveniant but they bring a hard link to mavlink that can be harmfull codewise.

Therefore, we got a recent effort to reduce this dependency : see https://github.com/ArduPilot/ardupilot/pull/23229 . In this PR, we decouple the GPS status from the mavlink enum. That lower our inclusion mess.

Describe the solution you'd like We should now update our codebase to remove the mavlink GPS enum in favor of the GPS_Status enum.

Some other work could be done to make the same for EKF and other mavlink enums !

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Platform [ X ] All [ ] AntennaTracker [ ] Copter [ ] Plane [ ] Rover [ ] Submarine

Additional context Add any other context or screenshots about the feature request here.

贡献者指南

技术栈
cpp
领域
backend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C++ knowledgeArduPilot codebasePR #23229 understanding
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Start by reviewing the decoupling changes made in PR #23229 to understand the new GPS Status enum. Then search the codebase for remaining uses of mavlink GPS enum and replace them with the new GPS Status enum. Ensure consistency with the existing patterns used in the PR. After completing the GPS enum replacements, consider extending similar decoupling to other mavlink enums like EKF, as suggested in the issue.