Hacktoberfest 2026：維護者為十月標記出來的 issue，仍然開放、適合新手。 瀏覽 Hacktoberfest issue

from_dataset re-reads every dimension coordinate on each call, and the workaround loses the cftime UDF and template registry

未關閉
  • 哪裡不對？
#238 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
1-2 天
新手友好度
45/100
Issue 類型
功能
描述清晰度
基本清楚
活躍度
冷清
技術堆疊
python, sql
領域
api, data

研究方向

Start in XarrayContext.from_dataset, where coord_arrays is built once per call, and in read_xarray_table, which already takes coord_arrays. Also check _registered_datasets and _maybe_register_cftime_udf. Done means one Dataset can register several per-variable tables with each dimension coordinate read once, while metadata recovery and the cftime() UDF still work. The issue proposes two API shapes and the maintainers have not picked one, so confirm the direction before coding.

由索引模型根據 Issue 內容生成。

描述

Problem

XarrayContext.from_dataset materialises the dimension coordinates once per call:

coord_arrays = {
    str(dim): input_table.coords[dim].values for dim in input_table.dims
}

Within a single call those arrays are shared across every dim group, which is what the comment above them describes. Across calls nothing is shared. Registering one table per data variable, which is what you want when each variable should be its own SQL table, re-reads every coordinate once per variable.

Measured with a counting DataArray.values property, 4 data variables on a (time, lat, lon) grid:

4 x from_dataset (one per data var): 12 coord reads
1 x from_dataset (whole dataset)   : 3 coord reads

Local NumPy makes this free. On a Zarr store each read is a network round trip, so registration cost scales with n_vars * n_dims instead of n_dims.

The obvious workaround is not equivalent

read_xarray_table already accepts coord_arrays, so the natural caller-side fix is to read the coordinates once and register the tables directly:

shared = {str(d): ds.coords[d].values for d in ds.dims}
ctx = XarrayContext()
for v in ds.data_vars:
    ctx.register_table(v, read_xarray_table(ds[[v]], chunks, coord_arrays=shared))

That does share the reads, but bypassing from_dataset silently drops two things it does.

  1. self._registered_datasets[name] = input_table is never populated, so XarrayDataFrame loses metadata recovery. Checked: _registered_datasets is {} afterwards, and to_dataset() then returns empty attrs and cannot infer dims.

  2. _maybe_register_cftime_udf never runs, so the cftime() UDF is missing on a 360_day dataset:

cftime() escape hatch : ERR ValueError Error during planning: Invalid function 'cftime'. Did you mean 'to_time'?
cftime() from_dataset : 4 rows

So today there is no public way to register several tables out of one Dataset without either paying n_vars * n_dims coordinate reads or giving up metadata recovery and cftime support.

Possible directions

Either shape would fix it:

  • Accept coord_arrays on from_dataset (the parameter already exists one layer down in read_xarray_table), so a caller registering several tables from one parent Dataset can hand in the arrays it already read.
  • Add a per-variable split to from_dataset, alongside the existing dim-group split, so a single call can register air, hum and so on as separate tables from one Dataset. This keeps the coordinate sharing, the _registered_datasets tracking and the cftime UDF registration together in one place.

Parent: #126

主要語言
Python
星號
142
分支
19
平均合併
1 天 6 小時
30 天內合併 PR
10

環境準備

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

xqlsystems/xarray-sql 的其他 Issue

查看 xqlsystems/xarray-sql 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。