BitShuffle#shuffle for arrays of primitive datatypes does not consider the byte-order (leading to wrong results)

未關閉
#297 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
35/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
停滯
技術堆疊
java
領域
backend

研究方向

Start by locating the Java wrapper methods for BitShuffle shuffle and unshuffle and the tests that cover primitive arrays; the issue names no file or test. Check how those methods pass arrays to the native library and how platform byte order is handled. Done means primitive-array shuffle/unshuffle results are consistent across little- and big-endian platforms.

由索引模型根據 Issue 內容生成。

描述

The underlying BitShuffle library works internally with an algorithm that was designed for the little-endian format. For this reason, the input data must always be passed in little-endian format.

However, the snappy-java wrapper directly passes an int[] array with the native byte order. Thus the Java implementation does not give the same results on little-endian and big-endian platforms for the shuffle / unshuffle methods.

The shuffle/unshuffle methods still work bijective so this issue is not easily noticeable.

How to fix:

The data array based on primitive types (e.g. int[], short[], long[], etc.) must be converted to little-endian format in the Java implementation if executed on big-endian platforms (before passing the buffer to the external library).

主要語言
Java
星號
1.1k
分支
261
平均合併
2 分鐘
30 天內合併 PR
2

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

xerial/snappy-java 的其他 Issue

查看 xerial/snappy-java 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。