Native code for Mac in distribution jar is unsigned

未關閉
#658 3 則留言 1 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
35/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
停滯
技術堆疊
java
領域
build-system

研究方向

The affected files are the three macOS native libraries under org/xerial/snappy/native/Mac/ in the distribution jar. Start by inspecting how these binaries are produced and packaged, then check their signatures with Apple’s notarization tooling; done means each library is signed with a valid Apple Developer ID and passes notarization validation when included as a dependency.

由索引模型根據 Issue 內容生成。

描述

In the distribution jar, the files

org/xerial/snappy/native/Mac/aarch64/libsnappyjava.dylib,
org/xerial/snappy/native/Mac/x86/libsnappyjava.jnilib,
and
org/xerial/snappy/native/Mac/x86_64/libsnappyjava.dylib,

are currently not properly signed with an Apple Developer ID.

While aarch64/libsnappyjava.dylib according to the signcode command (signcode -vvvvvv aarch64/libsnappyjava.dylib) does have a signature in principle, it is rejected by Apple's notarization mechanism when the jar is included as a dependency:

    { 
      "severity": "error",
      "code": null,
      "path": "[...]/lib/snappy-java-1.1.10.5.jar/org/xerial/snappy/native/Mac/aarch64/libsnappyjava.dylib",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "arm64"
    },

The files x86/libsnappyjava.jnilib and x86_64/libsnappyjava.dylib do not have a signature at all and are rejected as well:

    { 
      "severity": "error",
      "code": null,
      "path": "[...]/lib/snappy-java-1.1.10.5.jar/org/xerial/snappy/native/Mac/x86_64/libsnappyjava.dylib",
      "message": "The binary is not signed.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },

The signatures have been faulty/lacking at least since 1.1.10.5 up to the current release.

BTW: If anyone encounters this problem, a workaround is to unpack the jar, sign the files yourself, repack and sign the jar as well. For me, it worked best to use jar xf and jar cf for this. See also https://developer.apple.com/forums/thread/764017

主要語言
Java
星號
1.1k
分支
261
平均合併
2 分鐘
30 天內合併 PR
2

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

xerial/snappy-java 的其他 Issue

查看 xerial/snappy-java 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。