An older navigation can overwrite the URL after a newer navigation commits
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 55/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- node.js, playwright, typescript
研究方向
Read packages/void/src/pages/navigation-engine.ts around makeCommit() and packages/void/src/pages/client.ts around applyNavigationResource(). Run the reported parallel-integration Playwright test and inspect how it controls adapter update timing. Add regression coverage for both completion orders and the normal-navigation control; done means a superseded navigation cannot change the URL, head, scroll, or Deferred ownership, and the reproduction leaves both page and URL at /b.
由索引模型根據 Issue 內容生成。
描述
Description
An earlier navigation can commit its URL after a later navigation has already rendered and committed. This leaves the displayed page and browser URL pointing to different destinations.
Unlike #506, this occurs with default navigation options, without preserveState: true.
Environment
- Commit:
2ceab89154dc6e0c3fa5525f7bd4d1d5f3d0aa64 - Package version:
1.1.12 - OS: Ubuntu 24.04.3 LTS x86_64
- Node:
24.21.0 - Vite+:
1.3.0; Vitest:5.0.5 - Playwright:
1.64.1 - Chromium Headless Shell:
134.0.6998.35
Steps to reproduce
- Initialize the production
createVoidRouter()in a browser fixture with valid Pages responses for/aand/b, with View Transitions disabled. - Provide an adapter whose
applyUpdate()updates the displayed page but returns a controllable Promise for/a:
let releaseA!: () => void;
let enteredA!: () => void;
const gate = new Promise<void>(resolve => {
releaseA = resolve;
});
const entered = new Promise<void>(resolve => {
enteredA = resolve;
});
const adapter = {
// Other adapter methods omitted.
applyUpdate(pageData: { url: string }) {
document.getElementById('app')!.textContent = pageData.url;
if (pageData.url === '/a') {
enteredA();
return gate;
}
},
};
- Start navigation A, allow B to finish, and then release A:
const visitA = router.visit('/a');
await entered;
await router.visit('/b');
releaseA();
await visitA;
- Compare the displayed page with
window.location.pathname.
Actual behavior
The older navigation overwrites the URL after the newer navigation has committed:
| Value | Result |
|---|---|
| Displayed page | /b |
window.location.pathname |
/a |
A newly added Playwright integration test reproduced this in both runs. The normal-navigation control passed in both runs.
The test was executed through the repository's parallel-integration project:
vp test run packages/void/test/integration/pages-navigation-race.test.ts --project parallel-integration
The fixture serves the production Pages client through a local HTTP server and controls the adapter's update timing. This verifies the Core/browser race; it is not a full production-build test across every framework adapter.
Expected behavior
The displayed page and browser URL should both remain /b.
Once B has superseded A and committed, completing A's pending adapter update should not allow A to commit its URL or other navigation side effects.
Relevant implementation
In packages/void/src/pages/navigation-engine.ts, makeCommit() uses the pending resource ID when clearing pending state, but that check does not guard the remaining commit operations.
applyNavigationResource() in packages/void/src/pages/client.ts awaits the adapter update and then calls resource.commit(). Consequently, the older resource can still reach the history-writing path after the newer resource has committed.
Acceptance criteria
- A superseded navigation cannot overwrite the URL after a newer navigation commits.
- The reproduction above leaves both the displayed page and URL at
/b. - A superseded commit does not overwrite the newer page's head, scroll, or Deferred resource ownership.
- Regression coverage includes controlled adapter-update completion orders and a normal-navigation control.
- 主要語言
- TypeScript
- 星號
- 402
- 分支
- 32
- 平均合併
- 10 小時 51 分鐘
- 30 天內合併 PR
- 100
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
voidzero-dev/void 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 72/100
voidzero-dev/void#529 ·
維護者通常 1 天內回覆
-
bug
難度 1/5 1-3 小時 新手友好度 78/100
voidzero-dev/void#428 ·
維護者通常 1 天內回覆
-
難度 3/5 1-2 天 新手友好度 56/100
voidzero-dev/void#527 ·
維護者通常 1 天內回覆
-
難度 3/5 1-2 天 新手友好度 54/100
voidzero-dev/void#525 ·
維護者通常 1 天內回覆
-
難度 3/5 1-2 天 新手友好度 67/100
voidzero-dev/void#524 ·
維護者通常 1 天內回覆
查看 voidzero-dev/void 的全部 Issue
相似的 Issue
-
bug
難度 2/5 1-3 小時 新手友好度 78/100
endora-commerce/endora-commerce#397 ·
維護者通常 1 天內回覆
-
level/task
難度 2/5 1-3 小時 新手友好度 68/100
wazuh/wazuh-dashboard-plugins#9472 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 63/100
維護者通常 1 天內回覆
-
ready-for-agent
難度 2/5 1-3 小時 新手友好度 68/100
xavxyz/bei-shan-lin-shui#57 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
opennextjs/opennextjs-cloudflare#1461 ·
維護者通常 1 天內回覆