Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

An older navigation can overwrite the URL after a newer navigation commits

Aperta
  • Qualcosa non va?
#507 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
node.js, playwright, typescript
Ambito
frontend, testing

Direzione di ricerca

Read packages/void/src/pages/navigation-engine.ts around makeCommit() and packages/void/src/pages/client.ts around applyNavigationResource(). Run the reported parallel-integration Playwright test and inspect how it controls adapter update timing. Add regression coverage for both completion orders and the normal-navigation control; done means a superseded navigation cannot change the URL, head, scroll, or Deferred ownership, and the reproduction leaves both page and URL at /b.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Description

An earlier navigation can commit its URL after a later navigation has already rendered and committed. This leaves the displayed page and browser URL pointing to different destinations.

Unlike #506, this occurs with default navigation options, without preserveState: true.

Environment

  • Commit: 2ceab89154dc6e0c3fa5525f7bd4d1d5f3d0aa64
  • Package version: 1.1.12
  • OS: Ubuntu 24.04.3 LTS x86_64
  • Node: 24.21.0
  • Vite+: 1.3.0; Vitest: 5.0.5
  • Playwright: 1.64.1
  • Chromium Headless Shell: 134.0.6998.35

Steps to reproduce

  1. Initialize the production createVoidRouter() in a browser fixture with valid Pages responses for /a and /b, with View Transitions disabled.
  2. Provide an adapter whose applyUpdate() updates the displayed page but returns a controllable Promise for /a:
let releaseA!: () => void;
let enteredA!: () => void;

const gate = new Promise<void>(resolve => {
  releaseA = resolve;
});
const entered = new Promise<void>(resolve => {
  enteredA = resolve;
});

const adapter = {
  // Other adapter methods omitted.
  applyUpdate(pageData: { url: string }) {
    document.getElementById('app')!.textContent = pageData.url;

    if (pageData.url === '/a') {
      enteredA();
      return gate;
    }
  },
};
  1. Start navigation A, allow B to finish, and then release A:
const visitA = router.visit('/a');
await entered;

await router.visit('/b');

releaseA();
await visitA;
  1. Compare the displayed page with window.location.pathname.

Actual behavior

The older navigation overwrites the URL after the newer navigation has committed:

Value Result
Displayed page /b
window.location.pathname /a

A newly added Playwright integration test reproduced this in both runs. The normal-navigation control passed in both runs.

The test was executed through the repository's parallel-integration project:

vp test run packages/void/test/integration/pages-navigation-race.test.ts --project parallel-integration

The fixture serves the production Pages client through a local HTTP server and controls the adapter's update timing. This verifies the Core/browser race; it is not a full production-build test across every framework adapter.

Expected behavior

The displayed page and browser URL should both remain /b.

Once B has superseded A and committed, completing A's pending adapter update should not allow A to commit its URL or other navigation side effects.

Relevant implementation

In packages/void/src/pages/navigation-engine.ts, makeCommit() uses the pending resource ID when clearing pending state, but that check does not guard the remaining commit operations.

applyNavigationResource() in packages/void/src/pages/client.ts awaits the adapter update and then calls resource.commit(). Consequently, the older resource can still reach the history-writing path after the newer resource has committed.

Acceptance criteria

  • A superseded navigation cannot overwrite the URL after a newer navigation commits.
  • The reproduction above leaves both the displayed page and URL at /b.
  • A superseded commit does not overwrite the newer page's head, scroll, or Deferred resource ownership.
  • Regression coverage includes controlled adapter-update completion orders and a normal-navigation control.
Lingua principale
TypeScript
Stelle
402
Fork
32
Merge medio
11h 52m
PR unite (30g)
88

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di voidzero-dev/void

Tutte le issue di voidzero-dev/void

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.