Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

fix(directive): input names with lone surrogates are emitted in oxc's internal U+FFFD encoding

Abierto
  • ¿Algo no está bien?
#505 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
68/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
angular, rust, typescript
Área
compilers

Línea de trabajo

Start with get_property_key_name in directive/property_decorators.rs and its copied decorator helpers, then trace class_metadata/builders.rs and the JS and dts.rs emitters. Use the lone-surrogate repro to compare OXC output with ngtsc; done means names and string values preserve lone code units as writable \uXXXX escapes and the generated TypeScript is valid.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

A member name written with a lone surrogate escape ('x-\uD800') comes out of OXC as x-<U+FFFD>d800: U+FFFD followed by the hex code unit. This is how oxc_ast stores lone surrogates in StringLiteral::value when lone_surrogates is true. We use value as a normal string and never decode it. ngtsc writes \uD800.

So the binding name at runtime (x-<U+FFFD>d800) doesn't match the class field (x-\uD800).

Repro

import {Directive, Input} from '@angular/core';
@Directive({selector: '[d]'})
export class D {
  @Input() 'x-\uD800': any;
  @Input({transform: (v: string) => 1}) 'y-\uD800': number = 0;
}

OXC (#504 tip, 3e0b07f). � below is the U+FFFD character

static ɵdir = i0.ɵɵdefineDirective({type:D,selectors:[["","d",""]],inputs:{"x-�d800":"x-�d800",
    "y-�d800":[2,"y-�d800","y-�d800",(v) =>1]}});
// setClassMetadata
{"x-�d800":[{type:Input}],"y-�d800":[{type:Input,args:[{transform:(v) =>1}]}]}

static ɵdir: i0.ɵɵDirectiveDeclaration<D, "[d]", never, { "x-�d800": { "alias": "x-�d800"; "required": false; }; "y-�d800": { "alias": "y-�d800"; "required": false; }; }, {}, never, never, true, never>;
static "ngAcceptInputType_y-�d800": string;

ngtsc 22.1.7

static ɵdir = i0.ɵɵdefineDirective({ type: D, selectors: [["", "d", ""]], inputs: { "x-\uD800": "x-\uD800", "y-\uD800": [2, "y-\uD800", "y-\uD800", (v) => 1] } });
// setClassMetadata
{ "x-\uD800": [{ type: Input }], "y-\uD800": [{ type: Input, args: [{ transform: (v) => 1 }] }] }

static ɵdir: i0.ɵɵDirectiveDeclaration<D, "[d]", never, { "x-\uD800": { "alias": "x-\uD800"; "required": false; }; "y-\uD800": { "alias": "y-\uD800"; "required": false; }; }, {}, never, never, true, never>;
static "ngAcceptInputType_y-\uD800": string;

Where

  • Main and the stack both read the key with .value: directive/property_decorators.rs (get_property_key_name) and class_metadata/builders.rs (get_property_key_name). The same helper is copied into the component, pipe, NgModule, injectable and service decorator modules.
  • Strings are printed by the JS emitter and by dts.rs (escape_dts_string, and the ngAcceptInputType_ quoting in generate_input_transform_fields). None of them handle the encoding.

On main?

Yes. On main the field is printed unquoted, static ngAcceptInputType_y-�d800: unknown;, which is not valid TS. The stack (#496) quotes it and types it, but the name still uses the internal encoding.

Direction

Decode lone_surrogates strings when reading names and string values. Keep the lone code units in a form the emitters can write back as \uXXXX.

Lenguaje dominante
Rust
Estrellas
232
Forks
21
Merge medio
1 d 18 h
PR fusionados (30 d)
59

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de voidzero-dev/oxc-angular-compiler

Todos los issues de voidzero-dev/oxc-angular-compiler

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.